Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks failing on push #2040

Closed
richnoah opened this issue Sep 14, 2021 · 9 comments
Closed

Checks failing on push #2040

richnoah opened this issue Sep 14, 2021 · 9 comments
Assignees
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@richnoah
Copy link
Contributor

richnoah commented Sep 14, 2021

During the checks run as part of a push a check is failing stating that the index.html has changed. The reporter, @jongund, states that as part of his commit he has not changed index.html.

An example of this error can be seen on the following PRs:

#1893

#1895

Investigation is need to identify the reason for this error and steps to take on providing a fix.

@nschonni
Copy link
Contributor

Fix is #2036

@jongund
Copy link
Contributor

jongund commented Sep 15, 2021

@nschonni @mcking65
Nick, I tried rerunning the "Jobs" for pull #1893 and pull #1895 and they are still failing the examples\index.html test.

@nschonni
Copy link
Contributor

@jongund because the PR I linked to hasn't landed. If you want to run npm run reference-tables on one of your PRs, it will fix the issue as well.

@jongund
Copy link
Contributor

jongund commented Sep 21, 2021

@nschonni
I tired running npm run reference-tables it didn't seem to help.

@nschonni
Copy link
Contributor

OK, I think the issue on your PRs is that the branches are "behind", so when you run it locally, it's not seeing the full set of the changes, but when CI is run, it runs on top of a patch on the default branch, so sees the full changes. The easiest fix is probably my linked PR then

@jongund
Copy link
Contributor

jongund commented Sep 21, 2021

@nschonni
What has to happen to get your PR merged?

@jongund
Copy link
Contributor

jongund commented Sep 22, 2021

@nschonni @mcking65
I merged main and then re-generated the examples index and the conflict seems to have gone away for the switch examples.

@nschonni
Copy link
Contributor

#2036 has landed now, and main is green again. Some of the open PRs might need a rebase if they're CI is currently red, but I think this can be closed now

@jongund
Copy link
Contributor

jongund commented Sep 28, 2021

I think I understand how to fix my PRs now. Thank you for your help.

@a11ydoer a11ydoer added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Apr 5, 2022
@jongund jongund closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

No branches or pull requests

5 participants