Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the date picker dialog example to design pattern page #2341

Open
a11ydoer opened this issue May 20, 2022 · 6 comments
Open

Add the date picker dialog example to design pattern page #2341

a11ydoer opened this issue May 20, 2022 · 6 comments

Comments

@a11ydoer
Copy link
Contributor

a11ydoer commented May 20, 2022

Feedback from Terrill Thompson at Educause IT accessibility Community. It will be also plus if we can add "search" section for the design pattern. (Adding "search" is in the next project milestone.)

"I'm pretty sure APG v 1.1 included a calendar widget as an example. I'm not sure if that was still present in v 1.2, or if it's still present in the new version. If I search the home page for "calendar" I get no results, but maybe it's out there somewhere as an example of a particular design pattern - I'm just not sure which one. "

@aardrian
Copy link
Contributor

The date picker widget still has at least 24 open issues:
https://github.com/w3c/aria-practices/issues?q=is%3Aissue+is%3Aopen+date+picker

You can also see a to-do list in the project dedicated to it:
https://github.com/w3c/aria-practices/projects/27

As your links show, many of the patterns are not linked on the page but are still available via URL hacking. I cannot speak to why that is the case, but I don't think the pattern is in good enough shape to warrant linking.

Regardless, I suggest against linking it since there is a risk someone will assume it is production ready.

@a11ydoer a11ydoer changed the title Add the date picker dialog example to design pattern index page Add the date picker dialog example to design pattern page May 20, 2022
@a11ydoer
Copy link
Contributor Author

Feedback from Terrill Thompson at Educause IT accessibility Community. It will be also plus if we can add "search" section for the design pattern. (Adding "search" is in the next project milestone.)

"I'm pretty sure APG v 1.1 included a calendar widget as an example. I'm not sure if that was still present in v 1.2, or if it's still present in the new version. If I search the home page for "calendar" I get no results, but maybe it's out there somewhere as an example of a particular design pattern - I'm just not sure which one. "

This issue may be simply improving the info architecture or description of patterns so that calendar widget can be found easily, not only from Example index page.

@a11ydoer
Copy link
Contributor Author

a11ydoer commented May 20, 2022

@aardrian

The date picker widget still has at least 24 open issues: https://github.com/w3c/aria-practices/issues?q=is%3Aissue+is%3Aopen+date+picker

You can also see a to-do list in the project dedicated to it: https://github.com/w3c/aria-practices/projects/27

As your links show, many of the patterns are not linked on the page but are still available via URL hacking. I cannot speak to why that is the case, but I don't think the pattern is in good enough shape to warrant linking.

Regardless, I suggest against linking it since there is a risk someone will assume it is production ready.

Thanks for looking into Date Picker pattern open issue and the project board. However, your judgement is soley on the number of Github issues. I don't see any critical bugs for this example unless I missed it. Also in the project board, we add topics to enhance the pattern example or feedback. The project board is not the indication of this pattern is "not good enough"

It would be more productive/constructive feedback if you can exactly point out "why you don't think the pattern is in good enough shape to warrant linking." by filing a github issue like others. APG working group is happy to work on those issues.

Furthermore, there is the misunderstanding that APG aims to provide for "production ready widget". I hope you can find time to read "About APG"

@mcking65

@aardrian
Copy link
Contributor

Thanks for looking into Date Picker pattern open issue and the project board. However, your judgement is soley on the number of Github issues. I don't see any critical bugs for this example unless I missed it.

It is not my judgment. It was my assumption the date picker is not linked is because it has that many open issues. It was my mistake for assuming that as opposed to some other decision process. I apologize for that. I also did not look to see which of the open issues were marked critical.

Furthermore, there is the misunderstanding that APG aims to provide for "production ready widget". I hope you can find time to read "About APG"

On that point I have been raising my concerns for years (at least since 2017).

@a11ydoer
Copy link
Contributor Author

@aardrian Thanks for the response.

Menu navigation example is where we are still asked for the clarification. Even we had one feedback about the menu example pattern today. I did not have the chance to re-read your Github issue Clarify Purpose of Menu Navigation #353 yet. But I will do any follow up if needed.

My point about the "About APG" page is that we don't aim to provide a "production ready widget". (Who would use simple vanilla javascript code to create the widget while there are lots of great JS library widgets? :-) ) In other words, ARIA APG WG tries to help people to understand how to use ARIA via various design pattern examples.

@a11ydoer
Copy link
Contributor Author

@aardrian I might also misunderstand your "production ready" concept. (I was busy with wrapping up the work for the weekend.) You might mean "production ready" for new APG site.

As one useful info, APG will be ever green document with this new APG site, not necessarily "production ready" concept for examples. (We are working on provding the updated date info and semantic indication for any updated example.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants