Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsable Listbox example: aria-expanded guidance is ambiguous #618

Open
DavidMacDonald opened this issue Mar 15, 2018 · 0 comments
Open

Collapsable Listbox example: aria-expanded guidance is ambiguous #618

DavidMacDonald opened this issue Mar 15, 2018 · 0 comments
Assignees
@mcking65
Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question

Comments

@DavidMacDonald
Copy link

DavidMacDonald commented Mar 15, 2018 •
edited
Loading

The table says aria-expanded is

Set by the JavaScript when the listbox is displayed. Otherwise, is not present.

Developers are interpreting this as the aria-expanded attribute not being present at all when listbox is collapsed and then when open the entire attribute is added with the property of "true" in it, then the complete attribute is removed when collapsed. I don't think that is what is intended.

It should be set to "false" when closed and "true" when open.
https://www.w3.org/TR/wai-aria-1.1/#aria-expanded
I don't think it is as clear with the full attribute being added and removed, and no "false" state announced.

Recommended change:

Set to "false" on page load, and toggled to "true by the JavaScript when the listbox is displayed. Then toggled back to "false" when it is closed.
@mcking65 mcking65 added question Issue asking a question Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force labels Jul 20, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 3 milestone Jul 20, 2018
@mcking65 mcking65 changed the title Listbox example Aria expanded usage column ambiguous instructions Collapsable Listbox example: aria-expanded guidance is ambiguous Jul 20, 2018
@mcking65 mcking65 self-assigned this Jul 20, 2018
@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 13, 2019
@eps1lon eps1lon mentioned this issue Oct 18, 2019
Merged
@mcking65 mcking65 modified the milestones: 1.2 Release 1, 1.2 Release 2 Dec 9, 2019
@dballesteros7 dballesteros7 mentioned this issue Aug 27, 2021
Closed
@mcking65 mcking65 removed this from the Launch Redesigned APG milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Projects
Listbox Pattern and Examples Development Project
Status: Next Steps
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidMacDonald @mcking65