Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change method for displaying alert in code example #672

Open
ZoeBijl opened this issue Apr 28, 2018 · 0 comments
Open

Change method for displaying alert in code example #672

ZoeBijl opened this issue Apr 28, 2018 · 0 comments
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Apr 28, 2018

@stevefaulkner reran his ARIA alert support tests. The alert example currently uses a method that doesn’t offer optimal support for all AT/UA combinations (method #2 from article). We should switch to method #3 which is based on the CSS display-property.

@mcking65 I remember we changed this before based on research you’d read/done. Do you have any objections to this change?
@ZoeBijl ZoeBijl added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZoeBijl