Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Accordion group behavior around forcing one open accordion at a time #1829

Open
smhigley opened this issue Mar 23, 2021 · 1 comment · May be fixed by #1834
Open

Revisit Accordion group behavior around forcing one open accordion at a time #1829

smhigley opened this issue Mar 23, 2021 · 1 comment · May be fixed by #1834
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern

Comments

@smhigley
Copy link
Contributor

This issue comes from discussion around #1819

We've had comments & observations that the current behavior of forcing one accordion open at a time in the current example is unexpected and confusing, especially as the default behavior. There are some examples where it does make sense to have this sort of managed behavior in a group of accordions, though -- for example, moving through a series of steps where one must be open at a time. Because of that, it does make sense to model the behavior and semantics in some way.

This issue is to discuss how best to do that. Right now we have two suggestions:

  1. Add a checkbox for this behavior to the current example, similar to the one on the disclosure widget for navigation example
  2. Add a second example with a clearer use case, e.g. a series of steps in a payment process.
@smhigley
Copy link
Contributor Author

These are two draft PRs that demo each suggested approach:

  1. Checkbox in current example: Draft: Accordion example with checkbox to switch behaviors #1833
  2. Separate examples: Two accordion examples, one basic and one of a group with only one open accordion #1834

@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Oct 4, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 4, 2021
@mcking65 mcking65 removed this from the 1.2 Release 1 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Development

Successfully merging a pull request may close this issue.

2 participants