-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API flow #177
API flow #177
Conversation
@mattsaxon can you include submission of the original .PUML file into the repo as part of this PR? We can update the image src when it is merged. |
I have a few comments on this PR:
|
you make a good point on the complexity. I'd like to seek others opinions on if the diagram should be external to the spec or if I should work on a more simplified diagram to include in the spec. Or indeed both? In terms of implementation dependence, this could either be provided as an example externally or I could remove the implementation dependence and keep it strict and in the spec. The purpose of this PR is to see if any type of flow would be useful and if it is then we should accept this PR and then revise the flow in future PRs IMO. |
I have been thinking that the spec would benefit from a diagram, but I have been thinking the diagram should be in an appendix. I can also see the benefit of a simplified diagram with links to the more complete diagrams in the flows repository. Ultimately I think we should decide based on the content of the diagram and the value it adds to the spec (and we can figure out formatting separately, use of SVG, etc.). Matt if you are game to try a simplification, that would be interesting to me. Ian |
Sure, I'll try a simplification, does that mean we merge this PR or close it? My understanding was that the consensus view was to iterate quickly and hence favour acceptance over rejection, then others can contribute too and see the progress. |
@mattsaxon we don't need to merge it or close it unless you'd like to close it. I'd suggest simply pushing some changes to satisfy the comments made by @ianbjacobs and @adrianba and letting the conversation continue in this thread until there is consensus to either merge or close. |
I've worked on a simplified diagram, taken it from 28 interactions down to 20 and from 6 actors down to 5. Hopefully this makes it more useful and relevant. |
Thanks for working on the diagram. Here are my thoughts:
Ian |
@mattsaxon - a few more comments on the diagram
|
@mattsaxon - I have made the changes I suggest on my own fork: |
Not discussed on 12 May, postponed to 19 May |
I think it would helpful to describe the functions of each actor/component underlying the flows, and highlight where changes are in comparison with legacy.
By the way (this is not a flow problem, but an important ulterior thought) this would help providing responses to merchants and acquiring PSP who have important strategic questions as: I want to know what I need to change on my site, which interface I should use, can I find here a strategic advantage and so on. |
To finalize the transaction, the Payee PSP generally exchanges a request/response with the Payer PSP, who authenticates the payer and approves the amount ; this is typical in card flows. |
There's a lot of discussion here about informative content describing how to utilise the API. We have also received other questions and feedback to the working group indicating the need for a primer document explaining how to best take advantage of the API and how flows might work. I can live with adding this diagram if that is the consensus of the group but I strongly recommend that the group consider picking up work on such a primer document rather than adding this to the normative implementation specification. There appears to be sufficient discussion and interest in the topic that such a work stream would be successful. |
Closed per F2F discussion. |
Added Basic API flow diagram to specification to show standard use of the API.