Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document type declarations for SMIL? #1371

Closed
murata2makoto opened this issue Oct 27, 2020 · 3 comments
Closed

Document type declarations for SMIL? #1371

murata2makoto opened this issue Oct 27, 2020 · 3 comments
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation

Comments

@murata2makoto
Copy link
Contributor

EPUB media overlay uses a subset of SMIL. Although SMIL has DTDs, EPUB media overlay does not use them. Instead, MO has relied on RELAX NG, Schematron, and NVDL for validation. I thus propose not to allow SMIL DTDs in EPUB. Do people agree?

This issue is to create § B. Allowed External Identifiers as proposed in #1368.

@mattgarrish
Copy link
Member

We're using a modified version of the DAISY profile, I believe, so I don't think it's really an option to specify a doctype in media overlay files.

/cc @marisademeglio @danielweck

@marisademeglio
Copy link
Contributor

Media Overlays doesn't reference the DAISY profile, which, as far as I am aware, was never implemented in the real world. MO doesn't specify a baseProfile attribute and doesn't have a DTD. We don't explicitly prohibit a doctype declaration though.

@mattgarrish mattgarrish added Topic-ContentDocs The issue affects EPUB content documents Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation and removed Topic-ContentDocs The issue affects EPUB content documents labels Oct 30, 2020
@iherman
Copy link
Member

iherman commented Nov 6, 2020

This issue was discussed in a meeting.

  • RESOLVED: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373
View the transcript Wendy Reid: we had resolutions at the F2F, and further discussions on github
… and came to a happy place
Matt Garrish: #1368
Matt Garrish: where we ended up was…
… we put in an allowance for a specific set of external identifiers that we have put in an appendix
… we have SVG and MathML that are allowed to be used in content docs or in separate files
… and we made a restriction against external entities in the internal DTD subset
… so it prevents some security issues but eases authoring
… so we’ll no longer force people to remove SVG DTDs from tool-generated files
… I’m hoping this is it :)
Ivan Herman: tech comment
… in fact, the changes are such that
… makes possible something that I’m not sure we really use
… I can define as part of an internal entity something that won’t go out to the network
… I’m not sure if this feature is in use
… formal comment
… there was a formal resolution on the previous version; this PR slightly changes that
… can we get a formal resolution to merge, and also close a bunch of issues which were examples of the problem?
Proposed resolution: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373 (Wendy Reid)
Garth Conboy: +1
Matt Garrish: +1
Ivan Herman: +1
Charles LaPierre: +1
Matthew Chan: +1
Wendy Reid: +1
Brady Duga: +1
George Kerscher: +1
Laura Brady: +1
Bill Kasdorf: +1
Ben Schroeter: +1
Resolution #1: Merge PR #1368 to address outstanding DTD issues, and close GH issues 1369-1373

@iherman iherman closed this as completed Nov 6, 2020
@mattgarrish mattgarrish added EPUB33 Issues addressed in the EPUB 3.3 revision and removed EPUB33 Issues addressed in the EPUB 3.3 revision labels Nov 9, 2020
@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPUB33 Issues addressed in the EPUB 3.3 revision Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation
Projects
None yet
Development

No branches or pull requests

4 participants