Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning for "SVG hyperlinks should have a human-readable title" seems too strict #1353

Closed
pkra opened this issue Sep 28, 2022 · 0 comments
Closed

warning for "SVG hyperlinks should have a human-readable title" seems too strict #1353

pkra opened this issue Sep 28, 2022 · 0 comments
Assignees
@rdeltour
Labels
status: completed Work completed, can be closed type: false-positive This issue is about valid content being incorrectly rejected
Milestone
v5.0.0-beta

Comments

@pkra
Copy link
Member

pkra commented Sep 28, 2022

Using v5.0.0-beta-2, the following minimal example produces 2 warnings of the following form:

WARNING(ACC-011): [..] SVG hyperlinks should have a human-readable title (using the "title" child element or the "xlink:title" attribute).

This seems overly strict - aria-label and text descendants are valid ways to label a link in SVG.

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops">
<head>
  <title>SVG anchor test</title>
</head>

<body>
<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg">
  <a href="https://developer.mozilla.org/en-US/docs/Web/SVG/Element/circle" aria-label="circle">
    <circle cx="50" cy="40" r="35" />
  </a>
  <a href="https://developer.mozilla.org/en-US/docs/Web/SVG/Element/text">
    <text x="50" y="90" text-anchor="middle">text</text>
  </a>
</svg>

</body>
</html>
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected labels Nov 17, 2022
@rdeltour rdeltour self-assigned this Nov 17, 2022
@rdeltour rdeltour added this to the v5.0.0-beta milestone Nov 17, 2022
@rdeltour rdeltour added status: in progress The issue is being implemented by the development team and removed status: accepted Ready to be further processed labels Nov 21, 2022
@rdeltour rdeltour added status: completed Work completed, can be closed and removed status: in progress The issue is being implemented by the development team labels Dec 1, 2022
@rdeltour rdeltour mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: completed Work completed, can be closed type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Milestone
v5.0.0-beta
Development

No branches or pull requests
2 participants
@pkra @rdeltour