Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnessasary recursion. #1356

Closed
wants to merge 2 commits into from
Closed

Remove unnessasary recursion. #1356

wants to merge 2 commits into from

Conversation

kalaspuffar
Copy link
Contributor

Hi Team.

I was trying to validate a law collection book with a nav document with 33k lines at a 2Mb in size.

Sadly recursively running the structure was not a viable option. I think I changed it, so it should have a similar function but not be recursive.

Best regards
Daniel

@rdeltour
Copy link
Member

Thanks for the PR @kalaspuffar.
I'm waiting a bit before merging this, as the whole class have been refactored in the ongoing branch for v5.0.0.
I will apply/rebase this PR against the branch when it is pushed to main.

@rdeltour rdeltour mentioned this pull request Nov 15, 2022
Closed
rdeltour added a commit that referenced this pull request Nov 28, 2022
@rdeltour @kalaspuffar
fix: remove recursion in reading order checks
6cbbefa 
Unnecessary recursion was causing StackOverflowError with large package documents.

Fix #1358, Close #1356.

Co-Authored-By: Daniel Persson <kalaspuffar@users.noreply.github.com>
@rdeltour rdeltour self-assigned this Dec 1, 2022
@rdeltour rdeltour mentioned this pull request Dec 5, 2022
Merged
@rdeltour
Copy link
Member

rdeltour commented Dec 5, 2022

Closing this PR, which is now replaced by #1434.

@rdeltour rdeltour closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rdeltour rdeltour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalaspuffar @rdeltour