Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does display:none need special-casing? #58

Open
npm1 opened this issue Aug 26, 2020 · 2 comments
Open

Does display:none need special-casing? #58

npm1 opened this issue Aug 26, 2020 · 2 comments

Comments

@npm1
Copy link
Collaborator

npm1 commented Aug 26, 2020

Currently in Chrome implementation, LCP will handle display:none elements as if they were removed elements, see https://test-lcp-displauy-none.glitch.me/

This seems fine but needs to be specified. We should wait for experimentation on removed content before making further clarification on this though.

@noamr
Copy link
Contributor

noamr commented May 13, 2022

Potentially add an LCP entry uses intersection rects. There would be no intersection rects for display: none elements. So maybe this is already covered?

@yoavweiss
Copy link
Contributor

At the very least, we'd need to add a note indicating this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants