Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track.getCaptureHandle() observes navigation even after capture ends #9

Closed
jan-ivar opened this issue Feb 11, 2022 · 4 comments
Closed

Comments

@jan-ivar
Copy link
Member

The way track.getCaptureHandle() appears defined, the application can observe the user's navigation in the other tab long after tab capture of it has ended.

This is a privacy issue and defies user expectations. Users can forcefully revoke screen capture today in all browsers through browser UX, and would expect this tracking to stop when the track ends.

@alvestrand
Copy link

This can be solved by adding "If the track is ended, return null" to the checks. I don't see a reason not to do that.

Again, this does not seem a reasonable concern for blocking adoption.

@jan-ivar
Copy link
Member Author

That would be a reasonable solution, as long as we agree this is not a part of the intended design.

@eladalon1983
Copy link
Member

I implicitly assumed that getCaptureHandle() should stop working after the capture stops. Thank you for bringing up the issue, that it should be mentioned explicitly how it "stops working."

  • Harald suggests returning null.
  • For completeness - we could also return undefined.
  • There is also the alternative of raising an exception.

I'll modify the document to return null.

@eladalon1983
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants