Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marching Percussion instruments need unique Sound IDs #494

Open
zacjansheski opened this issue Oct 13, 2023 · 4 comments · May be fixed by #495
Open

Marching Percussion instruments need unique Sound IDs #494

zacjansheski opened this issue Oct 13, 2023 · 4 comments · May be fixed by #495

Comments

@zacjansheski
Copy link

zacjansheski commented Oct 13, 2023 •
edited
Loading

Adding Sound IDs for marching percussion instruments will allow them to be identified uniquely.
I would propose using these sound ids.

sound id="drum.snare-drum.marching"/
sound id="drum.snare-line.marching"/
sound id="drum.tenor-drum.marching"/
sound id="drum.tenor-line.marching"/
sound id="drum.multi-tenor-drum.marching"/
sound id="drum.multi-tenor-line.marching"/
sound id="drum.bass-line.marching"/
sound id="metal.cymbals.marching"/
sound id="drum.snare-drum.pipe-band"/
sound id="drum.tenor-drum.pipe-band"/
sound id="drum.bass-drum.pipe-band"/

Some programs define a solo marching drum and a drumline differently. Pipe band drummers use 'chips' to switch between solo drum and drumline.
@zacjansheski
Copy link
Author

At the risk of over-complicating this:

Perhaps adding these would lend to more comprehensive fall-back options

sound id="drum.bass-drum.pipe-band"/
sound id="drum.group.multi-bass"/
sound id="drum.group.multi-bass.marching"/
sound id="drum.group.multi-toms"/
sound id="drum.group.multi-toms.marching"/
sound id="drum.group.multi-toms.marching.line"/
sound id="drum.snare-drum.marching"/
sound id="drum.snare-drum.pipe-band"/
sound id="drum.snare-drum.marching.line"/
sound id="drum.tenor-drum.pipe-band"/
sound id="drum.tenor-drum.marching"/
sound id="drum.tenor-drum.marching.line"/
sound id="metal.cymbal.marching"/
sound id="metal.cymbal.marching.line"/

This is all open for discussion. I can submit a PR for this as well.

@mscuthbert
Copy link
Contributor

this seems reasonable. I'm inclined to accept. The sounds are quite different than orchestra. Might need flam variants for snares.

zacjansheski added a commit to zacjansheski/musicxml that referenced this issue Oct 24, 2023
@zacjansheski
Add Marching Percussion SoundIDs
797f15d 
Resolves w3c#494
@zacjansheski zacjansheski linked a pull request Oct 24, 2023 that will close this issue
Open
@zacjansheski
Copy link
Author

Please let me know if there is anything else I can do to help here :)

@mscuthbert
Copy link
Contributor

sorry! I was sick for a month and everything has gotten a bit behind. Hoping to jump on this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Marching Percussion SoundIDs zacjansheski/musicxml
2 participants
@mscuthbert @zacjansheski