Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticator selection extension - should makeCredential fail if no specified authenticator can be found? #227

Closed
vijaybh opened this issue Sep 29, 2016 · 9 comments

Comments

@vijaybh
Copy link
Contributor

vijaybh commented Sep 29, 2016

In https://w3c.github.io/webauthn/#extension-authenticator-selection the current text says that if the client cannot find any willing-and-able authenticator with one of the specified AAGUIDs, then it must just go ahead and use another authenticator. However in working through use cases it seems unlikely that such an authenticator will ever be acceptable to an RP that cared deeply enough to specify this extension. Of course a client can always ignore extensions, but it seems like a client that supports this extension could provide a better UX by failing out in this case (though maybe after waiting a bit so as not to enable fingerprinting of the client).

@rlin1
Copy link
Contributor

rlin1 commented Sep 29, 2016

The rationale was to make sure that the user gets prompted by some authenticator in order to know that someone is trying to figure out what authenticators are present on that machine.

So this don't fail but use other authenticator was intended as a privacy features as we heardprivacy complaints about a more generic authenticator discovery feature before (which it would be in the case of returning a silent error code if the preferred authenticator is not present).

@sangraecho
Copy link

Should we have to include an extension in ClientData that indicates which authenticator is selected during the client processing?
I think this will help RP make a decision whether makeCredential operation is successful or not.

@vijaybh
Copy link
Contributor Author

vijaybh commented Oct 26, 2016

@sangraecho no, this is expected to be figured out from the attestation which does include the AAGUID. See #152 for why this cannot be in the ClientData.

@nadalin
Copy link
Contributor

nadalin commented Sep 6, 2017

@gmandyam please give proposal or close

@equalsJeffH
Copy link
Contributor

@gmandyam notes in webauthn f2f tpac 2017-11-09: we can close this since there is an AAGUID extension in the spec, and @gmandyam will submit some additional client extensions that address some other open issues of his.

@nadalin
Copy link
Contributor

nadalin commented Nov 29, 2017

@gmandyam will submit some additional client extensions that address some of your other open issues

@emlun
Copy link
Member

emlun commented Nov 29, 2017

I think the privacy consideration about silent authenticator discovery is obsolete now that makeCredential, with hot-plugging, will always wait for timeout instead of failing early (#655, #687). So maybe we can let this extension fail the operation (i.e., just ignore the authenticator and keep waiting) instead of proceeding with a non-eligible authenticator.

@equalsJeffH
Copy link
Contributor

on 6-Dec-2017 webauthn call: we decided this is likely overall a non-issue presently and we want to allow impls and deployments to experiment in this space and we are punting this issue to L2 such that we can re-consider after we have more experience

@equalsJeffH equalsJeffH modified the milestones: CR, L2-WD-00 Dec 6, 2017
@nadalin nadalin modified the milestones: L2-WD-01, L2-WD-02 Feb 20, 2019
@equalsJeffH
Copy link
Contributor

we discussed on call today and decided to close it as this seems to be a non-issue given the 1.5 yrs of experience since we re-visited it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants