Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2.2. Generating a signature #332

Closed
jehrensvard opened this issue Jan 26, 2017 · 1 comment
Closed

5.2.2. Generating a signature #332

jehrensvard opened this issue Jan 26, 2017 · 1 comment
Assignees
Milestone

Comments

@jehrensvard
Copy link

I just noticed the following in section 5.2.2:

A raw cryptographic signature must assert the integrity of both the client data and the authenticator data. Thus, an authenticator SHALL compute a signature over the concatenation of the authenticatorData and the clientDataHash.

It may go without saying, but for the sake of clarity and consistency, I believe the wording should be:

/.../ compute a signature over the SHA256 HASH OF THE concatenation of the authenticatorData /.../

@equalsJeffH equalsJeffH self-assigned this Feb 1, 2017
@equalsJeffH equalsJeffH added this to the WD-05 milestone Feb 1, 2017
@equalsJeffH
Copy link
Contributor

@jehrensvard wrote:

It may go without saying, but for the sake of clarity and consistency, I believe the wording should be:

/.../ compute a signature over the SHA256 HASH OF THE concatenation of the authenticatorData /.../

Actually, performing the hash over the input message (the "concatenation of the authenticatorData and the clientDataHash" in this case) is inherently a part of the signature algorithm (whether RSA [1] or ECDSA [2]). Note that the U2F spec says only " signature. This is a ECDSA signature (on P-256) over the following byte string ..." (e.g., in section 4.3).

If folks feel strongly about it we can add a Note explaining this, but I'm not sure it is necessary.

[1] hashing the "message" input to the RSA signature algs is done in Section 9 of the PKCS#1 spec (now RFC8017).

[2] hashing the "message" input to the ECDSA signature alg is done in Step 4 of "DSA Signature Generation" of Section 2.2 in the poor man's version of ANSI X9.62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants