Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeCredential should be more precise than NotAllowedError in its last step #376

Closed
jyasskin opened this issue Mar 14, 2017 · 6 comments
Closed

Comments

@jyasskin
Copy link
Member

https://w3c.github.io/webauthn/#makeCredential ends with

Reject promise with a DOMException whose name is "NotAllowedError".

However, it can get to this step for a couple reasons besides the user disallowing the operation.

@vijaybh
Copy link
Contributor

vijaybh commented Mar 15, 2017

Just to add a bit of historical context, the current behavior is an attempt to balance providing feedback to the RP with maintaining privacy for the user. Might be a useful exercise to think through what's the most an RP can infer from the differences between these errors.

@jyasskin
Copy link
Member Author

It'd be good to extend the Privacy Considerations section to list the attacks we want to prevent. Without that, we aren't going to be rigorous about it.

@jyasskin
Copy link
Member Author

I've filed #382 to track the privacy considerations extension.

@selfissued
Copy link
Contributor

It seems to me like there's probably consensus to maintain the current behavior, for privacy reasons. If so, we should decide that and close this issue. Whereas, if we're going to make a change, we should do so before the Implementer's Draft, since it would affect interop.

@nadalin
Copy link
Contributor

nadalin commented Sep 6, 2017

@selfissued Can you please close per your last comment on privacy

@selfissued
Copy link
Contributor

Closing with no action per the privacy comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants