Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDDL to every extension #679

Closed
jcjones opened this issue Nov 9, 2017 · 4 comments
Closed

Add CDDL to every extension #679

jcjones opened this issue Nov 9, 2017 · 4 comments
Assignees
Milestone

Comments

@jcjones
Copy link
Contributor

jcjones commented Nov 9, 2017

The extensions currently describe their CBOR as example octets; these can be more precisely defined using CDDL, and we should add normative CDDL for each extension.

@ttaubert
Copy link

None of the example octets for the currently listed extensions use indefinite length encoding. When we define them using CDDL, can we add a note that allows definite length encoding only? That should simplify CBOR parsers quite a bit.

@jcjones
Copy link
Contributor Author

jcjones commented Nov 10, 2017

Avoiding indefinite length encoding is a good security goal in general, whatever the encoding format. Per @ttaubert, I'd recommend we add that to the implementation considerations as part of this change.

@kpaulh
Copy link
Contributor

kpaulh commented Nov 13, 2017

I agree. CTAP is already requiring their CBOR to be canonical, which means no indefinite length encoding.

@selfissued
Copy link
Contributor

There was agreement on the 28-Feb-18 call that CDDL isn't needed for most extensions, since the transformations between the JavaScript data structures and the CBOR data structures are now obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants