Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow callers to explicitly specify RP ID #198

Merged
merged 10 commits into from
Sep 28, 2016
Merged

Allow callers to explicitly specify RP ID #198

merged 10 commits into from
Sep 28, 2016

Commits on Sep 13, 2016

  1. Merge remote-tracking branch 'refs/remotes/origin/master' into vgb-ex… 

    …plicit-rpid
    @vijaybh
    vijaybh committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    6a2458e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into vgb-explicit-rpid

    @vijaybh
    vijaybh committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    6651690 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2016

  1. Allow caller to explicitly specify its claimed RP ID 

    Alternative to #162 as suggested by @balfanz. This change also gets rid
of references to PSL and eTLD+1, replacing them with references to the
HTML specification instead.
    @vijaybh
    vijaybh committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    443482e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2016

  1. Remove rpId from ClientData 

    Since rpId is now equal to origin except when explicitly specified by
the caller, and it is folded into the authenticatorData, having it in
ClientData adds no value.

Fixes #189
    @vijaybh
    vijaybh committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    a9c6b38 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/master' into vgb-ex… 

    …plicit-rpid
    @vijaybh
    vijaybh committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    7cbf57a View commit details
    Browse the repository at this point in the history

  3. Incorporate feedback from @equalsJeffH

    @vijaybh
    vijaybh committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    7943865 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2016

  1. Merge from master

    @vijaybh
    vijaybh committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    782a6d5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into vgb-explicit-rpid

    @vijaybh
    vijaybh committed Sep 20, 2016
    Configuration menu
    Copy the full SHA
    a79f880 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2016

  1. More feedback from @equalsJeffH

    @vijaybh
    vijaybh committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    f44ba9e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Incorporate feedback from @equalsJeffH 

    Note this PR also fixes #178 by removing all use of the term lowercase
    @vijaybh
    vijaybh committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    f03e4e5 View commit details
    Browse the repository at this point in the history