New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mismatch in colorSpace parameter to Convert to RGB frame #831

Closed

jyasskin opened this issue Sep 4, 2024 · 0 comments · Fixed by #835

Assignees

Member

jyasskin commented Sep 4, 2024 •

edited

Loading

https://w3c.github.io/webcodecs/#dom-videoframe-copyto takes a colorSpace of type PredefinedColorSpace, an enum of "srgb" and "display-p3". It passes it to https://w3c.github.io/webcodecs/#videoframe-convert-to-rgb-frame, which assigns it to https://w3c.github.io/webcodecs/#dom-videoframe-color-space-slot of type VideoColorSpace, which is a whole constructible interface. There needs to be a conversion of some sort in there.

I think this was introduced in #754. cc/ @Djuffin

Djuffin mentioned this issue

Convert PredefinedColorSpace to VideoColorSpace #835

Merged

Djuffin self-assigned this

Djuffin closed this as completed in #835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment