Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an updated proposal for DOM Parts. #899

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

rniwa
Copy link
Collaborator

@rniwa rniwa commented Oct 26, 2020

No description provided.

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 26, 2020

@justinfagnani
Copy link
Contributor

cc @yuzhe-han

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 26, 2020

@justinfagnani @yuzhe-han : would you like me to add acknowledgment for your involvement? I wasn't sure if you'd like to put your names on it or not.

@yuzhe-han
Copy link
Contributor

@rniwa : sure. I enjoyed our discussions and look forward to collaborating in the future. Thanks.

@justinfagnani
Copy link
Contributor

That would be great, thanks!

proposals/DOM-Parts.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to read more, but this looks interesting and seems like a good iteration given the previous feedback of the approach being too high-level. Once thing that's not entirely clear to me is what the internal model of a part is and why having it is beneficial other than developer ergonomics. Does this enable any performance wins over mutating the tree yourself, for instance?

proposals/DOM-Parts.md Outdated Show resolved Hide resolved
proposals/DOM-Parts.md Show resolved Hide resolved
@rniwa
Copy link
Collaborator Author

rniwa commented Oct 26, 2020

I still need to read more, but this looks interesting and seems like a good iteration given the previous feedback of the approach being too high-level. Once thing that's not entirely clear to me is what the internal model of a part is and why having it is beneficial other than developer ergonomics. Does this enable any performance wins over mutating the tree yourself, for instance?

Performance improvement is possible if we introduce some kind of batching.

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 26, 2020

@justinfagnani @hober @mfreed7 @yuzhe-han : Added the acknowledgement. Let's merge this so that people can take a look before tomorrow's meeting.

@justinfagnani
Copy link
Contributor

justinfagnani commented Oct 26, 2020

Once thing that's not entirely clear to me is what the internal model of a part is and why having it is beneficial other than developer ergonomics. Does this enable any performance wins over mutating the tree yourself, for instance?

Another big win for template libraries and hand-written DOM code is the cloning behavior. This would be the first way to clone some kind of reference to nodes, along with a subtree.

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 26, 2020

Can someone approve this PR?

@leobalter
Copy link

I'm interested but I'm trying to fit in time this afternoon to read it.

proposals/DOM-Parts.md Outdated Show resolved Hide resolved
proposals/DOM-Parts.md Outdated Show resolved Hide resolved
@annevk
Copy link
Collaborator

annevk commented Oct 27, 2020

If people want to read it they can do so at https://github.com/w3c/webcomponents/blob/405d041d8346355d11c1f1d426407488e7c16820/proposals/DOM-Parts.md. It does seem good to address the issues @myakura raised before merging. What's the best way to raise high-level issues? File a new issue with the templates label?

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 27, 2020

It does seem good to address the issues @myakura raised before merging.

Fixed. Can we merge it now? It would be really unhelpful for this PR to be continue to be open while more people keep adding more review comments here. It would be far better if this was merged into the repository and we filed issues instead.

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 27, 2020

What's the best way to raise high-level issues? File a new issue with the templates label?

File issues with [DOM Parts] probably since this new proposal is no longer anything to do with template elements per se.

@rniwa
Copy link
Collaborator Author

rniwa commented Oct 27, 2020

Alright, I added this to wiki page instead since this isn't getting approved by anyone.

@rniwa rniwa closed this Oct 27, 2020
@annevk
Copy link
Collaborator

annevk commented Oct 27, 2020

You gave me 8 minutes to reply? I'm happy to merge this in a bit.

@annevk annevk reopened this Oct 27, 2020
@annevk annevk merged commit 591675d into WICG:gh-pages Oct 27, 2020
@rniwa
Copy link
Collaborator Author

rniwa commented Oct 27, 2020

You gave me 8 minutes to reply? I'm happy to merge this in a bit.

Oh sorry, I thought you went off somewhere. Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants