Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browsingContext.navigate/reload HTML integration needs updating #371

Open
foolip opened this issue Feb 23, 2023 · 0 comments
Open

browsingContext.navigate/reload HTML integration needs updating #371

foolip opened this issue Feb 23, 2023 · 0 comments
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@foolip
Copy link
Member

foolip commented Feb 23, 2023

After whatwg/html#6315 we need to make some changes to await a navigation, used in the browsingContext.navigate and browsingContext.reload commands.

WebDriver BiDi generates and passes in a navigation id to HTML's navigate algorithm, but that doesn't have a navigation id argument, and instead has a navigationId variable which it sets itself.

The fix should probably be on the HTML side, to add (back?) that argument. Otherwise, WebDriver BiDi cannot know if the callbacks its getting are due to its own command, or other things happening at the same time.

cc @jgraham

@foolip foolip added the module-browsingContext Browsing Context module label Feb 23, 2023
@whimboo whimboo added the needs-discussion Issues to be discussed by the working group label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

2 participants