Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to browsingContext.close to skip beforeunload #462

Closed
Lightning00Blade opened this issue Jul 3, 2023 · 0 comments · Fixed by #518
Closed

Add flag to browsingContext.close to skip beforeunload #462

Lightning00Blade opened this issue Jul 3, 2023 · 0 comments · Fixed by #518
Labels
enhancement New feature or request module-browsingContext Browsing Context module

Comments

@Lightning00Blade
Copy link
Contributor

Lightning00Blade commented Jul 3, 2023

Original issue #170, Original discussion comment - #170 (comment)
The issue was no discussed in depth as that focused more on #187
Currently when we close a BrowsingContext we need to run close-a-top-level-traversable in there check if unloading is canceled.
From an user perspective I may want to close the BrowsingContext to free resources regardless if there is unload handlers or not.

Puppeteer CDP already supports this at Page.close,
where default is to skip beforeunload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module-browsingContext Browsing Context module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants