-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefetch request changes to improve privacy #398
Comments
Context: I was asked to comment here by @kenchris. I created and operate https://pika.dev/cdn. Edit: Posted in the wrong place, moved to blink-devContext: I was asked to comment here by @kenchris. I created and operate https://pika.dev/cdn. How are cross-origin CDNs considered in this change? My understanding is that this suggested change would kill the cache efficiency story of cross-origin CDNs, which is extremely troubling. The ability to cache resources across domains is a huge benefit to using cross-origin CDNs at scale. The more use that they get, the more likely cache hits are, and the faster those websites become (potentially faster than if they'd served their own JS). Two examples: 1. "This month, July 2019, cdnjs served almost 190 billion requests ... Lodash (4.17.11) skyrocketed to the top of the list this month with 8.7 billion requests."[1] 2. "Approximately 100% of the Fortune 500 already use npm to acquire approximately 97% of their JavaScript code." [2] Obviously security is a huge concern, and I completely understand and appreciate the work being done here. But as others have pointed out the perceived threat (cached file detection) doesn't outweight the serious performance hit for CDNs. As we moved towards bundling all of our JavaScript into custom site bundles over the last decade, cross-origin CDNs have gone out of fashion. But they clearly are still heavily used today (see cdnjs stats above), and we see them playing a big part in the future of the web once ESM becomes standard... as long as the current performance story isn't destroyed. tldr: https://twitter.com/rektide/status/1156261839623401472 (PS: Please add that single explainer doc! I read through the different threads but there's a chance I could have misunderstood/missed something, in which case please let me know!). |
@FredKSchott, Is your comment for double-keyed HTTP caching in general, or for this change specifically? |
Double-keyed HTTP caching in general. I'd originally read the PRs to be addressing that generally, but in re-reading I see that you're talking exclusively about prefetching logic. |
Yeah, so this issue and the Blink intent thread I posted. Concerns about Double-Key Cache in general should probably be brought up in Blink's intent thread for that change specifically, until a TAG review for it has been started. The thread's been pretty active so feel free to comment. |
Thanks all, I'll move my comment there instead 👍 |
Maybe relevant. |
Quite. Thanks! |
Is there any explainer in plan to get a better idea what's being done here? (maybe this document if of help). |
Might be useful context
|
@lknik I think it'll very much depend on usage data as per w3c/resource-hints#82 (comment). It's not entirely clear to me this feature is pulling its weight in a privacy-first world. |
TLDR: I don't think this is ready for a deep review by the TAG, I just wanted to file this issue very early while Chrome and other vendors get their stance straight and proposing ideas in case TAG had any early input.
Ah, yes I actually wrote that document. No explainer yet, as the ultimate direction is not entirely clear yet (sorry).
RE spec: I'll defer to @yoavweiss, as he is currently authoring the spec changes relevant here. But as Anne mentioned, I agree a lot of that is blocked on how implementations decide to move forward. To be clear: I think we'll likely not have any progress on this until after TPAC when vendors discuss this a bit more, so feel free to defer seriously at this looking until a meeting after 2019-09-04 (when the current label suggests this will be looked at closer). Just wanted to file an issue at the same time as I wrote Chromium's Intent-to-Implement to get his out earlier rather than later.
I will, however this won't be done until the direction is more clear (see above).
Ah, yes I wrote that too :) |
@annevk Are you mentioning that it might not be worth keeping prefetch around at all, or specifically not worth supporting cross-origin prefetch in a privacy-first world? |
Ok, we're going to close this issue for now. Feel free to ping us to re-open or file a new issue when it's ready for further review. |
こんにちはTAG!
I'm requesting a TAG review of:
Request
as well as related processing whatwg/fetch#881Further details:
You should also know that: Only early discussion has been going on regarding the changes to prefetch requests, and their processing model (HTML Standard PR above). We, Chrome, thought it would be best to request a TAG review early on as we're interested in making these changes in order to better-preserve privacy on the web platform. This is Blink's Intent thread. At the time of writing, the total compatibility effects of these changes are unknown, however we intend to experiment with an initial implementation. There has been some discussion from Apple regarding these changes as well.
We'd prefer the TAG provide feedback as:
The text was updated successfully, but these errors were encountered: