Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate repo #1388

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: migrate repo #1388

merged 2 commits into from
Apr 23, 2024

Conversation

joaosa
Copy link
Contributor

@joaosa joaosa commented Apr 23, 2024

  • Fixed CI permissions
  • Added a comment so we can trigger a release

vasco-santos
vasco-santos approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that given this is only NPM package publishing, we only need to test one of the packages flow (i.e. this will only trigger release to upload-api). Probably is good, but if you feel safer you can also do small change in each single package

@joaosa
Copy link
Contributor Author

joaosa commented Apr 23, 2024

I assume that given this is only NPM package publishing, we only need to test one of the packages flow (i.e. this will only trigger release to upload-api). Probably is good, but if you feel safer you can also do small change in each single package

We should be fine. Most of the package CI jobs are quite similar and self-contained (besides interacting with npm). If one runs correctly others should too.

@joaosa joaosa merged commit 10b7742 into main Apr 23, 2024
3 checks passed
@joaosa joaosa deleted the chore/migrate-repo branch April 23, 2024 14:05
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
vasco-santos added a commit that referenced this pull request Apr 25, 2024
@github-actions @vasco-santos
chore(main): release upload-api 10.0.1 (#1393)
60a1aeb 
🤖 I have created a release *beep* *boop*
---


##
[10.0.1](upload-api-v10.0.0...upload-api-v10.0.1)
(2024-04-25)


### Fixes

* add whitespace to trigger a release
([#1390](#1390))
([ec95a0e](ec95a0e))
* migrate repo
([#1388](#1388))
([10b7742](10b7742))
* migrate repo
([#1389](#1389))
([475a287](475a287))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@travis travis Awaiting requested review from travis

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaosa @vasco-santos