Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing of 'null' as output for null returning inputs. #187

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

kindermannhubert
Copy link
Collaborator

Removal of null interception in PrettyPrinter. See #88.
Now we analyze input and decide if the input is void-returning or no-output (->we output nothing) or if it is value-returning (-> we print even null result).

image

@codecov-commenter
Copy link

Codecov Report

Merging #187 (62c91d6) into main (8855650) will increase coverage by 0.0%.
The diff coverage is 92.1%.

@@          Coverage Diff          @@
##            main    #187   +/-   ##
=====================================
  Coverage   82.1%   82.1%           
=====================================
  Files         50      50           
  Lines       3707    3734   +27     
  Branches     467     471    +4     
=====================================
+ Hits        3044    3069   +25     
- Misses       477     478    +1     
- Partials     186     187    +1     
Impacted Files Coverage Δ
...harpRepl.Services/Roslyn/Scripting/ScriptRunner.cs 91.8% <88.4%> (-1.6%) ⬇️
CSharpRepl.Services/Roslyn/PrettyPrinter.cs 100.0% <100.0%> (ø)
CSharpRepl.Services/Roslyn/RoslynServices.cs 84.6% <100.0%> (ø)
...Repl.Services/Roslyn/Scripting/EvaluationResult.cs 66.6% <100.0%> (ø)
CSharpRepl/CSharpReplPromptCallbacks.cs 78.6% <100.0%> (ø)
CSharpRepl/ReadEvalPrintLoop.cs 91.0% <100.0%> (+1.2%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kindermannhubert kindermannhubert merged commit 9ab1823 into waf:main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants