From 1f26dbeeb60dd7b9333b9718eaecde67b05ba447 Mon Sep 17 00:00:00 2001 From: Limchansol Date: Mon, 25 Mar 2024 18:02:02 +0900 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=84=20=EB=94=94=EC=9E=90=EC=9D=B8=20qa?= =?UTF-8?q?=20=EB=B0=98=EC=98=81=20(#177)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: 시설 안내 아이콘 위치, 텍스트 색상 수정 * fix: 공지 목록 폰트 크기, 마진 수정 * fix: 연락처 이미지 위치 조정 * fix: 본문형 제목 line height 조정 * fix: 첨부파일 모바일뷰 수정 * fix: 모바일 소개 이미지 너비 꽉 차게 * fix: 시설 안내 반응형 * fix: 새소식 날짜 위치 변경 * fix: 신임교수초빙 html 스타일 변경 --- app/[locale]/about/contact/page.tsx | 2 ++ .../about/facilities/FacilitiesList.tsx | 10 ++++---- app/[locale]/about/history/page.tsx | 1 + app/[locale]/about/overview/page.tsx | 4 ++-- .../about/student-clubs/ClubDetails.tsx | 8 ++++++- .../community/faculty-recruitment/page.tsx | 2 +- .../community/news/[id]/NewsViewer.tsx | 19 +++++++++------ .../community/notice/[id]/NoticeViewer.tsx | 2 +- .../community/notice/helper/NoticeList.tsx | 2 +- .../community/notice/helper/NoticeListRow.tsx | 2 +- .../community/seminar/[id]/SeminarViewer.tsx | 2 +- .../community/seminar/helper/SeminarRow.tsx | 2 +- .../centers/ResearchCenterDetails.tsx | 8 ++++++- .../labs/[id]/ResearchLabDetailContent.tsx | 2 +- components/common/Attachments.tsx | 13 ++++------ components/common/ContentWithImage.tsx | 24 ++++++++++++------- components/editor/HTMLViewer.tsx | 10 +++++--- public/image/{about => }/distance.svg | 0 18 files changed, 71 insertions(+), 42 deletions(-) rename public/image/{about => }/distance.svg (100%) diff --git a/app/[locale]/about/contact/page.tsx b/app/[locale]/about/contact/page.tsx index 681fd83d1..ffa4c987f 100644 --- a/app/[locale]/about/contact/page.tsx +++ b/app/[locale]/about/contact/page.tsx @@ -16,7 +16,9 @@ export default async function ContactPage() { url: `https://cse-dev-waffle.bacchus.io/sites/default/files/styles/scale-width-220/public/node--contact/301.jpg?itok=zbUgVCfd`, widthPX: 240, heightPX: 360, + marginTopPx: 28, }} + className="mt-[-1.5rem]" /> ); diff --git a/app/[locale]/about/facilities/FacilitiesList.tsx b/app/[locale]/about/facilities/FacilitiesList.tsx index 377b0b04e..53d5070b8 100644 --- a/app/[locale]/about/facilities/FacilitiesList.tsx +++ b/app/[locale]/about/facilities/FacilitiesList.tsx @@ -1,4 +1,4 @@ -import Distance from '@/public/image/about/distance.svg'; +import Distance from '@/public/image/distance.svg'; import ImageWithFallback from '@/components/common/ImageWithFallback'; import HTMLViewer from '@/components/editor/HTMLViewer'; @@ -30,13 +30,13 @@ export interface FacilitiesRowProps { function FacilitiesRow({ name, description, location, imageURL }: FacilitiesRowProps) { return ( -
+

{name}

-
+
-

{location}

+

{location}

@@ -46,7 +46,7 @@ function FacilitiesRow({ name, description, location, imageURL }: FacilitiesRowP function FacilitiesRowImage({ imageURL }: { imageURL: string }) { return ( -
+
); diff --git a/app/[locale]/about/history/page.tsx b/app/[locale]/about/history/page.tsx index 9ba404f24..3df146835 100644 --- a/app/[locale]/about/history/page.tsx +++ b/app/[locale]/about/history/page.tsx @@ -15,6 +15,7 @@ export default async function History() { imageURL={history_image.src} imageWidth={320} imageHeight={360} + imageMarginBottom={0} /> ); diff --git a/app/[locale]/about/overview/page.tsx b/app/[locale]/about/overview/page.tsx index 9a3cf91c9..538d296a9 100644 --- a/app/[locale]/about/overview/page.tsx +++ b/app/[locale]/about/overview/page.tsx @@ -19,13 +19,13 @@ export default async function OverviewPage() {
{/* image 크기를 반응형으로 줄이기 위해 필요한 wrapper div */} -
+
학교 전경
diff --git a/app/[locale]/about/student-clubs/ClubDetails.tsx b/app/[locale]/about/student-clubs/ClubDetails.tsx index 100f5ef0a..7d8e1edb0 100644 --- a/app/[locale]/about/student-clubs/ClubDetails.tsx +++ b/app/[locale]/about/student-clubs/ClubDetails.tsx @@ -11,7 +11,13 @@ export default function ClubDetails({ return (
- +
); } diff --git a/app/[locale]/community/faculty-recruitment/page.tsx b/app/[locale]/community/faculty-recruitment/page.tsx index ec0bf1073..4049c77db 100644 --- a/app/[locale]/community/faculty-recruitment/page.tsx +++ b/app/[locale]/community/faculty-recruitment/page.tsx @@ -18,5 +18,5 @@ const mockNetwork = async () => mockResponse; const mockResponse: GETFacultyRecruitmentResponse = { latestRecruitmentPostHref: '', latestRecruitmentPostTitle: '2023년 제1차 교수초빙', - description: `

Seoul National University Computer Science & Engineering Faculty Hiring

The Department of Computer Science and Engineering in Seoul National University(SNU) is delighted to announcetwo faculty positions for recruitment in the 2024academic year (to start on 1st March 2024 or later).
We are looking foroutstandingcandidates in all areas of Computer Science & Engineering.
The two positions areat all ranks: tenure-track Assistant Professor, tenure-track Associate Professor, or tenured Full Professor.

The Seoul National University Computer Science and Engineering (SNU CSE) department comprises 35 full-time faculty members, along with approximately 350 graduate students and 400 undergraduate students. Our faculty members are at the forefront of world-class research & education, leading awide spectrum of research laboratories, spanning from theoretical foundations to computer systems and cutting-edge applications.

For further details, please email directly to our department head: head@cse.snu.ac.kr.

  • The closing date for applications will be during the period from 10-20 October, 2023.
  • The application materials include at least CV and more than two recommendation letters. Material submission will be done on-line through an official webpage, whose address will be announced shortly. Meanwhile, applicants are encouraged to reach out to the department head at head@cse.snu.ac.kr and submit their CVs for consideration.
  • With shortlisted candidates we will have interviews in person. Each interview (one or two-day long) includes a research presentationand one-on-one meetings with our faculty members.The interviews will be during the period of 10-30 November, 2023.
  • The final decision will be done during the period of 10-30 December, 2023.
`, + description: `

Seoul National University Computer Science & Engineering Faculty Hiring

The Department of Computer Science and Engineering in Seoul National University(SNU) is delighted to announcetwo faculty positions for recruitment in the 2024academic year (to start on 1st March 2024 or later).
We are looking foroutstandingcandidates in all areas of Computer Science & Engineering.
The two positions areat all ranks: tenure-track Assistant Professor, tenure-track Associate Professor, or tenured Full Professor.

The Seoul National University Computer Science and Engineering (SNU CSE) department comprises 35 full-time faculty members, along with approximately 350 graduate students and 400 undergraduate students. Our faculty members are at the forefront of world-class research & education, leading awide spectrum of research laboratories, spanning from theoretical foundations to computer systems and cutting-edge applications.

For further details, please email directly to our department head: head@cse.snu.ac.kr.

  • The closing date for applications will be during the period from 10-20 October, 2023.
  • The application materials include at least CV and more than two recommendation letters. Material submission will be done on-line through an official webpage, whose address will be announced shortly. Meanwhile, applicants are encouraged to reach out to the department head at head@cse.snu.ac.kr and submit their CVs for consideration.
  • With shortlisted candidates we will have interviews in person. Each interview (one or two-day long) includes a research presentationand one-on-one meetings with our faculty members.The interviews will be during the period of 10-30 November, 2023.
  • The final decision will be done during the period of 10-30 December, 2023.
`, }; diff --git a/app/[locale]/community/news/[id]/NewsViewer.tsx b/app/[locale]/community/news/[id]/NewsViewer.tsx index 6cbb6bdc6..e312a3204 100644 --- a/app/[locale]/community/news/[id]/NewsViewer.tsx +++ b/app/[locale]/community/news/[id]/NewsViewer.tsx @@ -28,19 +28,13 @@ export default async function NewsViewer({ id, searchParams }: NewsPostPageProps return ( <> -

- {news.title} -

- +
- @@ -48,3 +42,14 @@ export default async function NewsViewer({ id, searchParams }: NewsPostPageProps ); } + +function Header({ title, createdAt }: { title: string; createdAt: string }) { + return ( +
+

{title}

+ +
+ ); +} diff --git a/app/[locale]/community/notice/[id]/NoticeViewer.tsx b/app/[locale]/community/notice/[id]/NoticeViewer.tsx index dcf2602f9..bdc34c185 100644 --- a/app/[locale]/community/notice/[id]/NoticeViewer.tsx +++ b/app/[locale]/community/notice/[id]/NoticeViewer.tsx @@ -53,7 +53,7 @@ const Header = ({ }) => { return (
-

{title}

+

{title}

글쓴이: {author}

작성 시각: {formatPostDateStr(createdAt)}

diff --git a/app/[locale]/community/notice/helper/NoticeList.tsx b/app/[locale]/community/notice/helper/NoticeList.tsx index ba2fb67f2..f504d57e0 100644 --- a/app/[locale]/community/notice/helper/NoticeList.tsx +++ b/app/[locale]/community/notice/helper/NoticeList.tsx @@ -24,7 +24,7 @@ export default function NoticeList({ if (posts.length === 0) return ; return ( -
+
    {posts.map((post) => ( diff --git a/app/[locale]/community/notice/helper/NoticeListRow.tsx b/app/[locale]/community/notice/helper/NoticeListRow.tsx index 1ef146bdc..225065f35 100644 --- a/app/[locale]/community/notice/helper/NoticeListRow.tsx +++ b/app/[locale]/community/notice/helper/NoticeListRow.tsx @@ -120,7 +120,7 @@ function TitleCell({ title, hasAttachment, id, isEditMode, isPinned }: TitleCell {title} diff --git a/app/[locale]/community/seminar/[id]/SeminarViewer.tsx b/app/[locale]/community/seminar/[id]/SeminarViewer.tsx index 12f1641f4..06a9edc1a 100644 --- a/app/[locale]/community/seminar/[id]/SeminarViewer.tsx +++ b/app/[locale]/community/seminar/[id]/SeminarViewer.tsx @@ -23,7 +23,7 @@ export default async function SeminarViewer({ id, searchParams }: SeminarPostPag return ( <> -

    +

    {seminar.title}

    - + ); } diff --git a/app/[locale]/research/labs/[id]/ResearchLabDetailContent.tsx b/app/[locale]/research/labs/[id]/ResearchLabDetailContent.tsx index d3951925b..0efeb0fc5 100644 --- a/app/[locale]/research/labs/[id]/ResearchLabDetailContent.tsx +++ b/app/[locale]/research/labs/[id]/ResearchLabDetailContent.tsx @@ -31,7 +31,7 @@ export default function ResearchLabDetailContent({ lab }: { lab: ResearchLab }) ? { type: 'component', content: } : undefined } - className="mt-6 " + className="mt-6" />
    ); diff --git a/components/common/Attachments.tsx b/components/common/Attachments.tsx index 30d96dc56..174627aa7 100644 --- a/components/common/Attachments.tsx +++ b/components/common/Attachments.tsx @@ -11,15 +11,12 @@ export default function Attachments({ files }: { files: Attachment[] }) { if (files.length === 0) return <>; return ( - // 좌측 정렬을 위한 wrapper div -
    -
    - {files.map((file, index) => ( - - ))} +
    + {files.map((file, index) => ( + + ))} - -
    +
    ); } diff --git a/components/common/ContentWithImage.tsx b/components/common/ContentWithImage.tsx index c21991319..fc8aeb3c1 100644 --- a/components/common/ContentWithImage.tsx +++ b/components/common/ContentWithImage.tsx @@ -9,8 +9,9 @@ interface ContentWithImageProps { imageURL?: string | null; content: string; containerClassName?: string; - imageWidth?: number; - imageHeight?: number; + imageWidth: number; + imageHeight: number; + imageMarginBottom?: number; } export default function ContentWithImage({ @@ -19,24 +20,31 @@ export default function ContentWithImage({ containerClassName, imageWidth, imageHeight, + imageMarginBottom, }: ContentWithImageProps) { const { screenType } = useResponsive(); return (
    - {imageURL && ( -
    - + {screenType === 'mobile' && imageURL && ( +
    +
    )} +
    {(topRightContent?.type === 'image' || topRightContent?.type === 'imageUnoptimized') && ( )} @@ -56,9 +57,12 @@ export default function HTMLViewer({ function TopRightImageContent(props: TopRightImage) { if (props.type === 'image') { - const { url, widthPX: width, heightPX: height } = props; + const { url, widthPX: width, heightPX: height, marginTopPx: marginTop } = props; return ( -
    +
    대표 이미지
    ); diff --git a/public/image/about/distance.svg b/public/image/distance.svg similarity index 100% rename from public/image/about/distance.svg rename to public/image/distance.svg