Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit logs on missed blocks for getLogs fallback on watchEvent #220

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

jxom
Copy link
Member

@jxom jxom commented Mar 15, 2023

Fixed an issue where watchEvent would not emit events on missed blocks for the getLogs fallback (when an RPC Provider does not support getFilterChanges).

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 104c1ba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
viem ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 10:32PM (UTC)
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 10:32PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Size Change: -15 B (0%)

Total Size: 45.8 kB

Filename Size Change
dist/abi.js 256 B -1 B (0%)
dist/chains.js 1.59 kB -2 B (0%)
dist/chunk-5KPMXLJZ.js 0 B -1.38 kB (removed) 🏆
dist/chunk-XMKUHSC7.js 0 B -34.2 kB (removed) 🏆
dist/contract.js 437 B -2 B (0%)
dist/ens.js 343 B -1 B (0%)
dist/index.js 4.61 kB -4 B (0%)
dist/public.js 456 B -1 B (0%)
dist/test.js 504 B -2 B (0%)
dist/wallet.js 295 B -1 B (0%)
dist/chunk-IUZRZEEU.js 34.2 kB +34.2 kB (new file) 🆕
dist/chunk-VUA7GJVU.js 1.38 kB +1.38 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
dist/ethers.js 505 B
dist/utils/index.js 1.07 kB
dist/window.js 67 B

compressed-size-action

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #220 (104c1ba) into main (3c39478) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         221      221           
  Lines       13096    13096           
  Branches     1403     1404    +1     
=======================================
  Hits        13076    13076           
  Misses         19       19           
  Partials        1        1           
Impacted Files Coverage Δ
src/actions/public/watchContractEvent.ts 100.00% <100.00%> (ø)
src/actions/public/watchEvent.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant