fix: scope filters to their respective transport #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54dcff6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TldrThis PR fixes an issue where Filter querying was not being scoped to the Transport that created the Filter. It also adds a Detailed summary
|
|
Size Change: +1.31 kB (+1%) Total Size: 246 kB
ℹ️ View Unchanged
|
jxom
force-pushed
the
jxom/scope-filters
branch
2 times, most recently
from
1ebadd6
to
a0f88d0
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
a0f88d0
to
fc39f7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 99.89% 99.86% -0.04%
==========================================
Files 263 264 +1
Lines 19405 19519 +114
Branches 1819 1828 +9
==========================================
+ Hits 19384 19492 +108
- Misses 19 23 +4
- Partials 2 4 +2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jxom
force-pushed
the
jxom/scope-filters
branch
from
fa7fe7a
to
4a43117
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
4a43117
to
dac6fd3
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
dac6fd3
to
b7d8506
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
b7d8506
to
5bacf24
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
5bacf24
to
fe45655
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
fe45655
to
4e93584
Compare
jxom
force-pushed
the
jxom/scope-filters
branch
from
7cb9606
to
54dcff6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where filter querying (
eth_getFilterChanges, etc) was not being scoped to their respective transport that created the filter. We need these transports to be the same as the RPC node has context of the filter id. This is easily reproducible using a fallback transport due to the fallback (& ranking) behavior.We could possibly extend the
onResponsetransport "hook" infallbackto the other transports, but can just leave it as a private API (for this scenario) for now.Automated Summary
🤖 Generated by Copilot at 54dcff6
This pull request fixes an issue where filter querying was not being scoped to the transport that created the filter. It adds a utility function to create scoped request functions for filters, and updates the filter actions and types to use them. It also adds tests for the new functionality and the fallback transport, and fixes some typos and errors in the code and workflows.