feat: add inference to getLogs event
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f8d114 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 246 kB ℹ️ View Unchanged
|
|
Imho, there's also another issue with This woudl be better imho: export function getAbiItem<
TAbi extends Abi | readonly unknown[],
TItemName extends string,
>({
abi,
args = [],
name,
}: GetAbiItemParameters<TAbi, TItemName>): GetAbiItemReturnType<
TAbi,
TItemName
> {
const abiItems = (abi as Abi).filter((x) => 'name' in x && x.name === name)
if (abiItems.length === 0) return undefined as any
for (const abiItem of abiItems) {
if (!('inputs' in abiItem)) continue
if (!args || args.length === 0) {
if (!abiItem.inputs || abiItem.inputs.length === 0) return abiItem as any
continue
}
if (!abiItem.inputs) continue
if (abiItem.inputs.length === 0) continue
const matched = (args as readonly unknown[]).every((arg, index) => {
const abiParameter = 'inputs' in abiItem && abiItem.inputs![index]
if (!abiParameter) return false
return isArgOfType(arg, abiParameter as AbiParameter)
})
if (matched) return abiItem as any
}
return abiItems[0] as any
} |
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 264 264
Lines 19714 19714
Branches 1848 1850 +2
=======================================
Hits 19692 19692
Misses 20 20
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@fubhy nice catch! Want to make that a separate PR? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type inference to
getLogseventproperty#359 (reply in thread)
Automated Summary
🤖 Generated by Copilot at 3f8d114
This pull request enhances the type inference of the
getLogsfunction, which fetches logs from a smart contract event. It uses theNarrowandAbiEventtypes fromabitypeto narrow down the possible types of theeventparameter and the returned logs. It also adds some type tests usingvitestand documents the changeset in a markdown file.