feat: eth_call multicall aggregation
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6a80fb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jxom
force-pushed
the
jxom/aggregate-calls
branch
from
0caaf53
to
3010d16
Compare
jxom
commented
Apr 18, 2023
|
|
||
| const schedulerCache = new Map<number | string, SchedulerItem[]>() | ||
|
|
||
| export function createBatchScheduler< |
There was a problem hiding this comment.
/codex what does this function do?
There was a problem hiding this comment.
what does this function do?
@jxom This code snippet defines a TypeScript module that exports a function called createBatchScheduler. This function returns a batch scheduler that allows you to group multiple function calls and execute them together in a batch. The batch scheduler is useful when you have multiple function calls that can be combined into one call to improve performance.
|
Size Change: +4.37 kB (+2%) Total Size: 251 kB
ℹ️ View Unchanged
|
jxom
changed the title
eth_call multicall aggregationeth_call multicall aggregation
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
========================================
Coverage 99.89% 99.90%
========================================
Files 265 267 +2
Lines 21811 22060 +249
Branches 1849 1891 +42
========================================
+ Hits 21789 22038 +249
+ Misses 20 19 -1
- Partials 2 3 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tmm
approved these changes
Apr 19, 2023
| wait, | ||
| shouldSplitBatch(args) { | ||
| const size = args.reduce((size, { data }) => size + (data.length - 2), 0) | ||
| return size > batchSize * 2 |
| @@ -115,6 +115,7 @@ export async function simulateContract< | |||
| } as unknown as EncodeFunctionDataParameters<TAbi, TFunctionName>) | |||
| try { | |||
| const { data } = await call(client, { | |||
| batch: false, | |||
There was a problem hiding this comment.
Is batching okay for simulateContract? You can still pass in batch: true because it's not omitted from SimulateContractParameters (CallParameters).
There was a problem hiding this comment.
Oh no, it’s not okay. Good catch.
There was a problem hiding this comment.
Might be better to Pick<CallParameters, ...> versus Omit<CallParameters, ...>
src/utils/promise/index.ts
Outdated
There was a problem hiding this comment.
some pretty nice utils we have here :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
eth_callbatch aggregation via multicallaggregate3.PR-Codex overview
This PR introduces support for batch aggregation via multicall
aggregate3, adds a new error type, and makes several updates and fixes across multiple files.Detailed summary
eth_callbatch aggregation via multicallaggregate3ClientChainNotConfiguredErrorerror typecontract.tsexportspromiseandpromise.test.tsfileseip1193.ts.env.exampleindex.tsandindex.test.tsgetEnsName.test.ts,getEnsText.test.ts,getEnsAddress.test.ts,getEnsResolver.test.ts,readContract.test.ts,estimateContractGas.test.ts,simulateContract.ts, andsimulateContract.test.tsutils.tschain.tsandchain.test.tsgetContract.test.tsgetContractError.tscreatePublicClient.test.tsandcreatePublicClient.tsPR-Codex overview
This PR introduces support for
eth_callbatch aggregation via multicallaggregate3. It also adds a newbatchparameter toCallParametersto enable and configure the multicall feature.Detailed summary
eth_callbatch aggregation via multicallaggregate3.batchparameter toCallParametersto enable and configure the multicall feature.batchSizeandwaitto thebatch.multicallobject.scheduleMulticallfunction to handle multicall requests.shouldPerformMulticallto only perform a scheduled multicall if the request has calldata, has a target address, is not the aggregate3 signature, and has no other properties.callto useshouldPerformMulticallandscheduleMulticallwhen appropriate.createPublicClienttest to include the new batch parameter.