Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siri doesn't change the temperature #26

Open
cohenjonathan opened this issue Jul 8, 2018 · 9 comments
Open

Siri doesn't change the temperature #26

cohenjonathan opened this issue Jul 8, 2018 · 9 comments

Comments

@cohenjonathan
Copy link

When asking siri to change the temperatue, it's only do the following:
[7/8/2018, 11:22:55 AM] [Sensibo] Living room : Setting threshold (name: Living room , threshold: 22 )

When changing Manually using homekit it does the following:
[7/8/2018, 11:22:48 AM] [Sensibo] Living room State change set, current ACstate: cool new state: 2
[7/8/2018, 11:22:48 AM] [Sensibo] Living room - Submit state change: New state: cool On/Off Status: true
[7/8/2018, 11:22:49 AM] [Sensibo] Changed status (name: Living room , roomTemp: 25, on: true, mode: cool, targetTemp: 21, speed: auto)

It seems like Siri only sets a threshold instead of changing the status.
Is that in any way related to the name of the accessory?

Thanks!

@Cloudore
Copy link

Cloudore commented Jul 8, 2018 via email

@cohenjonathan
Copy link
Author

cohenjonathan commented Jul 9, 2018

Hey,
Not using IOS 12, and as i said, On/Off worked just perfectly fine, so i don't think its realted to how Siri work internaly/remotely.

I did find a workaround with a code edit.
I noticed that when changing with Siri, it changes the threshold and thats it:

// Cooling Threshold Temperature Characteristic
	this.getService(Service.Thermostat)
		.getCharacteristic(Characteristic.CoolingThresholdTemperature)
		.on("get", function(callback) {
			callback(null, that.coolingThresholdTemperature);
		})
		.on("set", function(value, callback) {
			callback();
			that.log(that.name,": Setting TThreshold (name: ",that.name,", threshold: ",value,")");
			that.coolingThresholdTemperature = value;
			//that.coolingThresholdTemperature = that.temp.temperature;
		});

I Ended by inserting the folowing line:
that.getService(Service.Thermostat).getCharacteristic(Characteristic.TargetTemperature).setValue(value, callback);

and off course removing the callback.

So evantually:

	// Cooling Threshold Temperature Characteristic
	this.getService(Service.Thermostat)
		.getCharacteristic(Characteristic.CoolingThresholdTemperature)
		.on("get", function(callback) {
			callback(null, that.coolingThresholdTemperature);
		})
		.on("set", function(value, callback) {
			that.log(that.name,": Setting TThreshold (name: ",that.name,", threshold: ",value,")");
			that.coolingThresholdTemperature = value;
			that.getService(Service.Thermostat).getCharacteristic(Characteristic.TargetTemperature).setValue(value, callback);
			//that.coolingThresholdTemperature = that.temp.temperature;
		});

Works perfectly fine, It would be great if the creator(@wailuen ) can spill some light on it.

Many thanks! :)

@leoneleone
Copy link

@JohnnatanCohen
Can you please submit a Pull Request with your fix for this issue?

@jsundgot
Copy link

jsundgot commented Oct 19, 2018

@JohnnatanCohen I second @leoneleone - I also lost the ability to alter temperature through Siri, and would very much like to regain it. Alternatively, if anyone could point me to directions for modifying the code I would be happy to give that a try.

@JoshKitson
Copy link

@JohnnatanCohen I third @leoneleone - Same situation, no temperature control through siri... through homekit manully works fine though...

@DarylMc
Copy link

DarylMc commented Nov 13, 2018

@JohnnatanCohen
Thanks that got Siri control of setpoint working for me.
I don't understand the changes but I will test and see if any other problems arise for me.

@ekatsili
Copy link

@JohnnatanCohen

Where do I need to place this code?

@shereefalkady
Copy link

you can find it in /usr/lib/node_modules/homebridge-sensibo-sky-7modes/accessories/pods.js

@imerin
Copy link
Collaborator

imerin commented Jul 17, 2019

Pr #36 implements this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants