-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match legacy wakatime-cli behavior around logging failed network connections #495
Comments
alanhamlett
added
bug
Something isn't working
p1
Medium Priority
and removed
feature request
triage
labels
Jul 6, 2021
Example error messages:
|
Receiving the above diagnostics is a side-effect of the bug, where we shouldn't be logging network problems as errors unless debug mode is enabled or offline mode disabled. |
Closed via #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that #385 is fixed, we're getting a lot of diagnostics logs from connection timeouts and other normal expected errors. For these "wontfix" errors, we should prevent sending diagnostics. The best way to do this is match the behavior of legacy wakatime-cli and only log errors when:
For reference, the legacy Python logic around logging failed network requests:
https://github.com/wakatime/wakatime/blob/master/wakatime/api.py#L123
The text was updated successfully, but these errors were encountered: