-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unofficial working solution for TB 102 #46
Comments
This one works, although it's looking a bit different than it used to. |
@defacto64 |
@AlexUkr73 |
Try to re-check settings manually like shown in post below Also try to play with setting "extensions.ldapinfoshow.service_priority":
|
@AlexUkr73 |
@Exatice72 Solution is not found on this moment. |
Unfortunately there is no any solution (after switching to vCard format in addressbook). https://bugzilla.mozilla.org/show_bug.cgi?id=1617490#c4 Reading photos from AddressBook will be implemented in version 106 and I'll try to adjust addon accordingly. |
Thanks for your answer. You said that photos for not modified contacts are still present in cache. What is the location of this cache and would it be possible to modify it ? Or it's not even worth thinking about it ! |
I don't know, really ;o) I see from the code, that when modifying contact it's photo is removed from cache and updated again if photo exist (this is broken). I've already played around with beta 106 version - new function seems not available yet. |
Hi AlexUkr73, Any news about your addon ? Will it be compatible with Thunderbird supernova ? I hope so ! In Thunderbird 114 it is now possible to display sender's profile picture, but this picture is much smaller than in the addressbook... |
@Exatice72 I developed it from scratch based on MailExtensions development guides from Mozilla developers to check - is it possible to pull any photos from AddressBook at all. When I realised that photos can be pulled - I reviewed LdapInfoShow code again to find the solution, but failed:
The biggest minus of SCF - delay on displaying photo icons - maybe the reason is monkey code (I'm just advanced PC user) + additional layer between addon and Thunderbird (ugly by design) But.... it runs on TB versions 91, 102. Plans:
I can not give any ETA for plans above, as this is tons of googling and thousands of wrong steps/attempts for amateur java coder. |
@AlexUkr73 As you said, it works on TB 102 even if I see the message "To protect your privacy, TB has blocked remote content in this message". So I allow remote content frome file://name-profile-thunderbird and all is ok. However, I noticed a surprising behavior with another user (Linux) on the same computer with TB 102 (with another profile) and SCF does not display AddressBook photos... Good luck with the rest of job |
I use Debian-based Linux for developing and testing with different Thunderbird versions:
Thunderbird releases are taken from https://download-installer.cdn.mozilla.net/pub/thunderbird/releases/ Different TB versions run with option to load defined profile, e.g. All profiles contain directory "Photos" with images (created by AddressBook to store photos from contacts setup) Path to profile can be found in TB from "Account Setting" -> "Local Folders" Hope this information will be useful. |
@Exatice72 |
@AlexUkr73 All is ok now with AddressBook with TB 102.4 ! Next step with TB 115 Supernova ?? Thanks for the job. |
Perfect. |
I've stopped developing of my own addon SCF (ShowContactFoto). Any approaches to improve performance did not work (due to Mozilla's security limitations with access to local filesystem) ;o( Addon is fully operable. |
Fix with AddressBook photos for SCF (for TB versions >106) According to information from developers: So, ShowContactFotos will be the only working solution as LdapInforShow does not work in TB 115 |
Fine ! |
It works for me too, @AlexUkr73, thank you! Have you thought of publishing your add-on to Github? |
@defacto64 I've already submitted addon to be added to official Thunderbird addons page. https://addons.thunderbird.net/en-GB/thunderbird/addon/showcontactfoto/ please note: |
@AlexUkr73 Would it be possible to have an option for displaying contacts only present in the address book or in local photos directory path ? Regards |
I think it is possible to add an opportunity for user in addon's options page to define whether to skip contacts without photo or to display selected "noname" image for them. |
So I'm going to wait for this next version ! Regards |
Hi, could you check version below with option to skip contacts without photo, please? If it is OK, i'll submit it to official addons repository. |
All seems ok ! Thanks for your job. |
Please note - version 0.8 is already approved and added to official addon repository, but has the bug:
Fixed in version 0.9 |
Sorry, but in version 0.9, photo does not display correctly on new email composing... |
I can not reproduce your issue in version 115.1.1 on my Linux desktop. |
@AlexUkr73 With Thunderbird 115.4.1 on my Linux desktop |
Sorry, but same issue in version 0.10... |
@AlexUkr73 Apologies for the inconvenience. |
Thank you for response. Do you have any additional addon-s which can interfere in compose window (e.g. any templates, etc.) I wonder why your issue does not reproduce for others even with blank message body? Do you use any kind of signature for composing (which can be defined in Account settings)? I have test accounts with/without it - but issue does not reproduce.. |
@AlexUkr73 I'll try to describe how the issue appears and... disappears. I write a second email, photo does not display but IF |
Thank you for more detailed scenario. |
@AlexUkr73 |
Fixed to work in TB 102.
InfoShow_102.zip
)
The text was updated successfully, but these errors were encountered: