Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magepack Shortcuts Do Not Work #596

Closed
sprankhub opened this issue Feb 20, 2023 · 0 comments · Fixed by wardenenv/images#6 or wardenenv/images#12
Closed

Magepack Shortcuts Do Not Work #596

sprankhub opened this issue Feb 20, 2023 · 0 comments · Fixed by wardenenv/images#6 or wardenenv/images#12
Labels
bug Something isn't working docker-images
Milestone

Comments

@sprankhub
Copy link
Contributor

According to #138, especially #138 (comment), you should be able to run the Magepack generate and bundle command with a shortcut.

Long: warden env exec magepack magepack generate [...]
Short: warden env exec magepack generate [...]

Long: warden env exec magepack magepack bundle
Short: warden env exec magepack bundle

However, this does not seem to work. For me, only the long version works.

Looking at https://github.com/wardenenv/images/blob/7fb6d1c3e52d55da356b568f50b8a7c494fe21b2/magepack/bin/generate.sh / https://github.com/wardenenv/images/blob/7fb6d1c3e52d55da356b568f50b8a7c494fe21b2/magepack/bin/bundle.sh, the commands try to execute /usr/bin/magepack. However, warden env exec magepack which magepack gives me /usr/local/bin/magepack. Hence, I think the path to the magepack executable simply needs to be fixed. If anyone would shortly verify my findings, I am happy to send a PR.

@navarr navarr added bug Something isn't working docker-images labels Feb 20, 2023
@navarr navarr added this to the Warden 1.0.0 milestone Feb 20, 2023
@navarr navarr linked a pull request Mar 8, 2023 that will close this issue
@navarr navarr closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker-images
Projects
Archived in project
2 participants