Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conflict Tunables between wasmer/wasmer_engine #1872

Closed
webmaster128 opened this issue Dec 4, 2020 · 2 comments · Fixed by #1924
Closed

Naming conflict Tunables between wasmer/wasmer_engine #1872

webmaster128 opened this issue Dec 4, 2020 · 2 comments · Fixed by #1924
Labels
bug Something isn't working

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented Dec 4, 2020

Describe the bug

According to Syrus' statement (CosmWasm/cosmwasm@950f631#r44799222), all symbols from the crate wasmer-engine should be available in wasmer. When I tried that, I ran into the naming conflict Tunables, which is the trait in wasmer-engine and the reference implementation in wasmer.

In my project, I resolved the conflict as follows:

use wasmer::{Bytes, Engine, Pages, Singlepass, Store, Target, Tunables as ReferenceTunables, JIT};
use wasmer_engine::Tunables;

because I don't think Tunables is not a great name for one specific Tunables implementation. Maybe we adopt this here? Or resolve the conflict differently.

Steps to reproduce

NA

Expected behavior

All symbols from wasmer_engine are re-exported in wasmer

Actual behavior

wasmer_engine::Tunables and wasmer::Tunables are different things.

Additional context

@webmaster128
Copy link
Contributor Author

I can work on this, but need a 👍/👎 if you would be happy with Tunables for the trait and ReferenceTunables (or BaseTunables) for the implementation.

@Hywan
Copy link
Contributor

Hywan commented Dec 11, 2020

I'm OK to try something. Ping me on your PR so that I can review it :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants