Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wasmer_runtime_code::memory::Atomic with std::sync::atomic atomics. #689

Merged
merged 3 commits into from
Aug 17, 2019
Merged

Replace wasmer_runtime_code::memory::Atomic with std::sync::atomic atomics. #689

merged 3 commits into from
Aug 17, 2019

Conversation

nlewycky
Copy link
Contributor

This means we lose op_new(), op_weak() and proxy() from the interface.

@nlewycky
Replace wasmer_runtime_code::memory::Atomic with std::sync::atomic at…
a3fe372 
…omics.

This means we lose op_new(), op_weak() and proxy() from the interface.
@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 17, 2019
@bors @nlewycky
Merge #689
dac86ee 
689: Replace wasmer_runtime_code::memory::Atomic with std::sync::atomic atomics. r=nlewycky a=nlewycky

This means we lose op_new(), op_weak() and proxy() from the interface.

Co-authored-by: Nick Lewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Aug 17, 2019

Build succeeded

@bors bors bot merged commit 8b22d40 into master Aug 17, 2019
@bors bors bot deleted the nlewycky/std-atomic branch August 17, 2019 19:19
@bjfish bjfish mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlewycky @bjfish