[fix issue #724] replace panic! with return Err() #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pventuzelo
requested review from
MarkMcCaskey and
syrusakbary
as code owners
syrusakbary
reviewed
Sep 3, 2019
syrusakbary
reviewed
Sep 3, 2019
Co-Authored-By: Syrus Akbary <me@syrusakbary.com>
Co-Authored-By: Syrus Akbary <me@syrusakbary.com>
|
@pventuzelo there are lint errors on this PR, once the suggestions are merged it should be good to go. For next times run |
|
@syrusakbary sorry for the lint error, completely forgot to |
syrusakbary
approved these changes
Sep 3, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2019
747: [fix issue #724] replace panic! with return Err() r=syrusakbary a=pventuzelo related to issue: #724 after the patch: ``` ./target/release/wasmer run reported_issues/panic_wasm_trap_occured_call_indirect.wasm sizeof(UAFME) = 4 execute_wasm: "wasm trap occured: `call_indirect` out-of-bounds" ``` Co-authored-by: Patrick Ventuzelo <ventuzelo.patrick@gmail.com> Co-authored-by: Patrick Ventuzelo <9038181+pventuzelo@users.noreply.github.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2019
747: [fix issue #724] replace panic! with return Err() r=syrusakbary a=pventuzelo related to issue: #724 after the patch: ``` ./target/release/wasmer run reported_issues/panic_wasm_trap_occured_call_indirect.wasm sizeof(UAFME) = 4 execute_wasm: "wasm trap occured: `call_indirect` out-of-bounds" ``` Co-authored-by: Patrick Ventuzelo <ventuzelo.patrick@gmail.com> Co-authored-by: Patrick Ventuzelo <9038181+pventuzelo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue: #724
after the patch: