Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API performance tests #1519

Merged
merged 5 commits into from
Sep 6, 2021
Merged

Conversation

AdriiiPRodri
Copy link
Contributor

@AdriiiPRodri AdriiiPRodri commented Jun 29, 2021

Related issue
#1490

Description

Hi team,

This PR closes #1490. In this PR we have updated the API performance tests based on the latest changes made in the main repo.

Also, we have added the xfailed flag to all tests that should fail until the following issues are fixed:

image

Test results

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs.
  • provision_documentation.sh generate the docs without errors.

@AdriiiPRodri AdriiiPRodri self-assigned this Jun 29, 2021
@vicferpoy vicferpoy self-requested a review June 29, 2021 08:27
vicferpoy
vicferpoy previously approved these changes Jun 29, 2021
Copy link
Contributor

@vicferpoy vicferpoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

davidjiglesias
davidjiglesias previously approved these changes Jun 29, 2021
@davidjiglesias davidjiglesias requested review from snaow and jmv74211 June 29, 2021 10:00
vicferpoy
vicferpoy previously approved these changes Jun 29, 2021
@AdriiiPRodri AdriiiPRodri force-pushed the 1490-api-performance-test-update branch 2 times, most recently from a18437b to 31c1199 Compare June 29, 2021 12:07
davidjiglesias
davidjiglesias previously approved these changes Jun 29, 2021
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, but some changes are required

tests/performance/test_api/data/configuration.yaml Outdated Show resolved Hide resolved
tests/performance/test_api/data/configuration.yaml Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
tests/performance/test_api/test_api.py Outdated Show resolved Hide resolved
@AdriiiPRodri AdriiiPRodri force-pushed the 1490-api-performance-test-update branch from 1edc50b to 7787ebc Compare September 2, 2021 08:29
Copy link
Member

@Rebits Rebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rebits
Copy link
Member

Rebits commented Sep 6, 2021

Local Status Report
R1 🟢 R1
R2 🟢 R2
R3 🟢 R3

@davidjiglesias davidjiglesias merged commit 61e35a8 into master Sep 6, 2021
@davidjiglesias davidjiglesias deleted the 1490-api-performance-test-update branch September 6, 2021 09:29
@snaow snaow mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update API performance tests
5 participants