Exploratory testing fixes #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelazoDS
reviewed
Aug 5, 2021
| @@ -12,24 +12,25 @@ | |||
| import json | |||
| import yaml | |||
| import ast | |||
| from Config import Config | |||
There was a problem hiding this comment.
We should remove the empty init.py file.
There was a problem hiding this comment.
The init.py file is required to convert the lib folder into a python module capable to be imported by the DocGenerator.py module.
There was a problem hiding this comment.
Good to know that, I thought it was only needed a lib folder.
MiguelazoDS
reviewed
Aug 5, 2021
| if not match: | ||
| return False | ||
| return True | ||
| if regex.match(file): |
MiguelazoDS
reviewed
Aug 5, 2021
| @@ -28,8 +25,8 @@ class CodeParser: | |||
| """ | |||
| brief: Class that parses the content of the test files. | |||
| """ | |||
| def __init__(self): | |||
| self.conf = Config() | |||
| def __init__(self, config): | |||
MiguelazoDS
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the fixes for the minor problems found during the exploratory testing: