-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIM IT: Fix file_limit and registry_limit test suites #3381
FIM IT: Fix file_limit and registry_limit test suites #3381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I would like that you update the description of the PR because I can see another case modified that isn't from the test_files/tests_file_limit
test suite that you mentioned.
@@ -171,7 +171,7 @@ def test_max_eps(configure_local_internal_options_module, get_configuration, con | |||
error_message=ERR_MSG_MONITORING_PATH).result() | |||
create_multiple_files(get_configuration) | |||
# Create files to read max_eps files with added events | |||
n_results = max_eps + 5 | |||
n_results = max_eps * 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the reason to change by *2
, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed because the max_eps+5 was the number of files that would be created, and then the number of results the FileMonitor is trying to get. The main issue was that this that later the results are filtered and it is checked if the number that happened a specific second matches the max_eps. having just 5 additional events is too small of a margin because the first/last 6 events could happen in another second (before or after) and that caused the event test to fail. By doubling the ammount of files/events generated, Now the having less than the expected events does not happen.
Currently, there are problems with the core branch, so the core team is working on fixing them. After checking the changes applied, and the executions launched by the developer. This PR is approved and merged with the intermediate branch. |
Description
This PR Aims to fix the tests related to the film database limit options
file_limit
andregistry_limit
. Also thetest_max_eps
test has been fixed.Updated
test_files/tests_file_limit
test suitetest_registry/test_registry_limit
test suitetest_files/test_max_eps
test suite flaky behaviorTesting performed
Conclusion
It is recommended that this branch is merged into branch https://github.com/wazuh/wazuh-qa/tree/1915-fim-rsync-new-synchronization-mechanism, and the errors caused by wazuh/wazuh#14956 and wazuh/wazuh#14957, are handled in that branch, since those errors are in tests not related to this Issue.