Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCA Test support #3566

Closed
wants to merge 43 commits into from
Closed

Add SCA Test support #3566

wants to merge 43 commits into from

Conversation

Deblintrake09
Copy link
Contributor

@Deblintrake09 Deblintrake09 commented Nov 4, 2022 •
edited by damarisg
Loading

Related issue
#3505

Description

This PR aims to add new test suite for SCA, testing it starts and performs scans properly.

Added

  • Added the new tests/integration/test_sca tests suite with 3 modules and 6 test cases.
  • Added the new deps/wazuh_testing/modules/sca framework for the SCA tests

Testing performed

Tester Test path Jenkins Local OS Commit Notes
Andres (Developer) test_integration/test_sca 🟢🟢🟢 🟢🟢🟢 Centos8 - Manager 32a84af
Andres (Developer) test_integration/test_sca 🟢🟢🟢 🟢🟢🟢 Centos8 - Agent 32a84af Nothing to highlight
Seyla (Reviewer) test_integration/test_sca 🟢 🚫 🚫 🚫 Centos8 - Manager 0e0bb37 Nothing to highlight
Seyla (Reviewer) test_integration/test_sca 🟢 🚫 🚫 🚫 Centos8 - Agente 0e0bb37 Nothing to highlight

@Deblintrake09 Deblintrake09 self-assigned this Nov 4, 2022
@Deblintrake09 Deblintrake09 linked an issue Nov 4, 2022 that may be closed by this pull request
Tests development - Check SCA scan runs properly with the new PCRE2 regex engine #3505
Closed
4 tasks
@Deblintrake09 Deblintrake09 marked this pull request as ready for review November 9, 2022 18:42
damarisg
damarisg requested changes Nov 16, 2022
View reviewed changes
deps/wazuh_testing/wazuh_testing/modules/sca/__init__.py Outdated Show resolved Hide resolved
deps/wazuh_testing/wazuh_testing/modules/sca/__init__.py Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/test_sca/test_enabled.py Outdated Show resolved Hide resolved
tests/integration/test_sca/test_scan_results.py Show resolved Hide resolved
tests/integration/test_sca/test_scan_results.py Outdated Show resolved Hide resolved
tests/integration/test_sca/test_scan_results.py Outdated Show resolved Hide resolved
tests/integration/test_sca/test_scan_results.py Outdated Show resolved Hide resolved
@damarisg @Deblintrake09
merge(#3653): merge PR #3653 from wazuh/3506-sca-support
17e085f 
SCA Test support - Validate remediation results
@jmv74211 jmv74211 changed the base branch from master to 4.5 February 1, 2023 10:21
damarisg
damarisg requested changes Mar 7, 2023
View reviewed changes
tests/integration/test_sca/conftest.py Outdated Show resolved Hide resolved
tests/integration/test_sca/data/policies/cis_centos8_osregex.yaml Outdated Show resolved Hide resolved
tests/integration/test_sca/data/policies/cis_centos8_pcre2.yaml Outdated Show resolved Hide resolved
tests/integration/test_sca/data/policies/cis_centos8_validate_remediation.yaml Outdated Show resolved Hide resolved
tests/integration/test_sca/data/policies/cis_centos8_validate_remediation.yaml Outdated Show resolved Hide resolved
tests/integration/test_sca/data/policies/cis_centos8_osregex.yaml Outdated Show resolved Hide resolved
tests/integration/test_sca/test_basic.py Outdated Show resolved Hide resolved
tests/integration/test_sca/test_validate_remediation.py Outdated Show resolved Hide resolved
@Deblintrake09 Deblintrake09 requested a review from damarisg March 23, 2023 13:44
juliamagan
juliamagan requested changes Apr 11, 2023
View reviewed changes
tests/integration/conftest.py Outdated Show resolved Hide resolved
@Deblintrake09 @juliamagan
docu(#3406): update documentation date
0e0bb37 
Co-authored-by: Julia Magán <80041853+juliamagan@users.noreply.github.com>
@Deblintrake09
Copy link
Contributor Author

Deblintrake09 commented May 15, 2023 •
edited
Loading

Updated Results

Tester Test path Jenkins Local OS Commit Notes
Andres (Developer) test_integration/test_sca 🟢🟢🟢 🟢🟢🟢 Centos8 - Manager 0e0bb37
Andres (Developer) test_integration/test_sca 🟢🟢🟢 🟢🟢🟢 Centos8 - Agent 0e0bb37 Nothing to highlight

@TomasTurina TomasTurina mentioned this pull request May 18, 2023
Closed
36 tasks
@damarisg damarisg dismissed juliamagan’s stale review May 29, 2023 12:30

The changes was applied.

@damarisg damarisg removed the request for review from juliamagan May 29, 2023 12:31
@Deblintrake09 Deblintrake09 removed a link to an issue May 29, 2023
Tests development - Check SCA scan runs properly with the new PCRE2 regex engine #3505
Closed
4 tasks
@Deblintrake09
Copy link
Contributor Author

Closing PR. Will be handled in #4212

@Deblintrake09 Deblintrake09 deleted the 3406-sca-pcre2-support branch July 4, 2023 12:23
@Rebits Rebits mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damarisg damarisg damarisg approved these changes

@juliamagan juliamagan juliamagan left review comments

Assignees

@Deblintrake09 Deblintrake09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deblintrake09 @damarisg @juliamagan @jmv74211