Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlmaLinux VDT IT support #4376

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Add AlmaLinux VDT IT support #4376

merged 9 commits into from
Aug 10, 2023

Conversation

mateocervilla
Copy link
Contributor

@mateocervilla mateocervilla commented Jul 28, 2023

Related issue
#3723

Description

For Wazuh v4.6.0 we want to add AlmaLinux support for the Wazuh Vulnerability Detector module.

For this reason, it was necessary to:

  • Add a custom feed.
  • Refactor the provider and feed tests.
  • Add independent tests for test_scan_results.

Modules involved:

  • test_vulnerability_detector/test_feeds/test_download_feeds.py
  • test_vulnerability_detector/test_feeds/test_duplicate_feeds.py
  • test_vulnerability_detector/test_feeds/test_import_invalid_feed_type.py
  • test_vulnerability_detector/test_feeds/test_validate_feed_content.py
  • test_vulnerability_detector/test_providers/test_enabled.py
  • test_vulnerability_detector/test_providers/test_missing_os.py
  • test_vulnerability_detector/test_providers/test_multiple_provider_feeds.py
  • test_vulnerability_detector/test_providers/test_os.py
  • test_vulnerability_detector/test_providers/test_update_from_year.py
  • test_vulnerability_detector/test_providers/test_update_interval.py
  • test_vulnerability_detector/test_scan_results/test_scan_nvd_vulnerabilities.py
  • test_vulnerability_detector/test_scan_results/test_scan_provider_and_nvd_vulnerabilities.py
  • test_vulnerability_detector/test_scan_results/test_scan_provider_vulnerabilities.py
  • test_vulnerability_detector/test_scan_results/test_scan_vulnerability_removal.py

Logs example

Test Path Os/Type Execution Type Results Date By
test/integration/test_vulnerability_detector/ Ubuntu - Manager Local 🟢🟢🟢 2023/07/28 @mateocervilla
test/integration/test_vulnerability_detector/ - Manager Jenkins ⚫ ⚫ ⚫

Notes:

  • On test R1, there are 4 errors and 5 failed
    • The errors are from test_validate_xml_feed_content[Canonical xxxxx]
      • These are caused due to the links https://people.canonical.com/~ubuntu-security/oval/... are invalid. They should be https://security-metadata.canonical.com/oval/...
    • The failed tests are from test_download_feeds[SUSE Linux xxxxx]
      • These are caused due to the SUSE servers are too slow and the download time is longer than the timeout. This can be solved downloading the .gz files.
  • For the tests R2 and R3, the previous issues were locally solved.
    • The error and failed test we can see on these tests are from test_validate_xml_feed_content[Red Hat Enterprise Linux0] and test_download_feeds[RHEL5]

@mateocervilla mateocervilla marked this pull request as ready for review July 31, 2023 22:16
@Dwordcito Dwordcito linked an issue Aug 1, 2023 that may be closed by this pull request
1 task
@Dwordcito Dwordcito self-requested a review August 1, 2023 13:29
@Dwordcito Dwordcito requested a review from pereyra-m August 1, 2023 13:29
@Dwordcito Dwordcito linked an issue Aug 1, 2023 that may be closed by this pull request
10 tasks
@mateocervilla mateocervilla force-pushed the 3723-almalinux-vd-it-support branch from c6d968b to 58c34a2 Compare August 1, 2023 21:04
@pereyra-m pereyra-m force-pushed the 3723-almalinux-vd-it-support branch from 1aed218 to 174bf50 Compare August 2, 2023 01:27
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dwordcito Dwordcito merged commit 41546a0 into 4.6.0 Aug 10, 2023
@Dwordcito Dwordcito deleted the 3723-almalinux-vd-it-support branch August 10, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AlmaLinux VDT IT support Add support for AlmaLinux OS in Vulnerability Detector
3 participants