Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIM System tests: 0212 - Realtime + Scheduled #562

Merged
merged 23 commits into from
Mar 2, 2020
Merged

FIM System tests: 0212 - Realtime + Scheduled #562

merged 23 commits into from
Mar 2, 2020

Conversation

spothound
Copy link
Contributor

Closes #556

spothound and others added 21 commits February 25, 2020 17:05
@spothound
Add linux agent configuration
71637ba
@spothound
Add windows realtime configuration
98c0a63
@spothound
Set recursion level on windows
772a0f7
@spothound
Merge branch 'feature-493-create-test-scenarios' of github.com:wazuh/…
16ee743 
…wazuh-qa into feature-531-realtime-scenario
@spothound
Fix problem with default boolean parameter
8f7e990
@spothound
Increase frequency in both linux and windows agents
8de08f5
@spothound
Wait for realtime engine to start
2e14420
@spothound
Add retry to alert check
6247db8
@spothound
Add extra vars option to verify_alerts.yml
8663242
@spothound
Fix problem with arguments in verify_alerts_json.py
114054e
@spothound
Clean agent logs when required
dd8f018
@spothound
Remove useless import
f323dac
@spothound
Merge branch 'feature-531-realtime-scenario' of github.com:wazuh/wazu…
006e8ca 
…h-qa into feature-556-realtime-scheduled-scenario
@spothound
Add 212 scenario
72a59ea
@spothound
Update configs
5ebcf76
@spothound
Improve logging elasticsearch
05c7cd4
@spothound
Restore default file sizes
88196b5
@spothound
Improve logging elasticsearch
a2043b8
@spothound
Minor changes in python scripts
0ab0430
@spothound
Minor changes in defaults
4d642e0
Delete files_generated.txt
ae33a07
jm404
jm404 reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grg121, just a little change request. Please check it.

tests/system/fim/scenarios/212_realtime_scheduled_monitoring/defaults/main.yml Outdated
@@ -0,0 +1,3 @@
elastic_verification_extra_arguments: "-r 3 -s 300"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe updating these values with set_fact before running the verify_alerts.yml in the launch_test_escenario.yml task is more explicit as we can see which parameters are being the tasks launched with. E.G:

wazuh-qa/tests/system/fim/scenarios/206_tag_option/launch_test_scenario.yml

Lines 11 to 15 in 9455e81

- name: Set extra arguments for scripts.
set_fact:
json_verification_extra_arguments: "-tg test_tag"
elastic_verification_extra_arguments: "-tg test_tag"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8a02576

jm404
jm404 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jm404 jm404 linked an issue Mar 2, 2020 that may be closed by this pull request
FIM System tests: 0212 - Realtime + Scheduled #556
Closed
5 tasks
jm404
jm404 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jm404 jm404 merged commit 2891476 into feature-493-create-test-scenarios Mar 2, 2020
@spothound spothound deleted the feature-556-realtime-scheduled-scenario branch January 27, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm404 jm404 jm404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIM System tests: 0212 - Realtime + Scheduled
2 participants
@spothound @jm404