Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements related to realtime #570

Merged
merged 19 commits into from
Mar 4, 2020
Merged

General improvements related to realtime #570

merged 19 commits into from
Mar 4, 2020

Conversation

spothound
Copy link
Contributor

Hello team, this PR is related with the issues:

Aims to add some missing required changes for those scenarios:

  • Delete file scripts add more attempts using recursion and have a sleep between each attempt to avoid problems in windows
  • Add/modify/delete scripts accepts parameters for file bunch size and sleep between bunchs
  • Add/modify/delete scripts accepts also a realtime_delay parameter to sleep between each action (for example 0.001 seconds between each file generated)
  • Improve logging (add timestamp and format)

@spothound spothound requested review from xr09, rshad and jm404 March 3, 2020 16:03
@spothound spothound self-assigned this Mar 3, 2020
xr09
xr09 approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@xr09 xr09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Zenidd
Zenidd suggested changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@Zenidd Zenidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grg121 , please have a look at requested changes

tests/system/fim/common_tasks/delete_files.py Outdated Show resolved Hide resolved
tests/system/fim/common_tasks/delete_files.py Outdated Show resolved Hide resolved
tests/system/fim/common_tasks/delete_files.py Show resolved Hide resolved
tests/system/fim/common_tasks/files_configuration.json.j2 Outdated Show resolved Hide resolved
jm404
jm404 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@jm404 jm404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spothound spothound merged commit 4762ec4 into feature-493-create-test-scenarios Mar 4, 2020
@jm404 jm404 deleted the feature-531-realtime-scenario branch March 5, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zenidd Zenidd Zenidd requested changes

@jm404 jm404 jm404 approved these changes

@xr09 xr09 xr09 approved these changes

@rshad rshad Awaiting requested review from rshad

Assignees

@spothound spothound

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spothound @xr09 @Zenidd @jm404