This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Make sync run immediately once git is ready #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that git mirroring is done in its own goroutine, something has to trigger the sync loop to do a sync. A "cell" (channel with buffer size 1) is used to prompt the sync loop every time the repo fetches from upstream. However, this only happens `git-poll-interval` _after_ the mirroring has started, and most of the time when the sync loop starts, the git repo isn't ready. That means the first successful sync, for a freshly-configured fluxd, is usually five minutes after starting. To compensate, this commit makes the repo signal on the cell when it moves to the ready state.
samb1729
approved these changes
May 8, 2018
|
Thanks Sam ❇️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that git mirroring is done in its own goroutine, something has to
trigger the sync loop to do a sync. A "cell" (channel with buffer size 1) is used to prompt the sync loop every time the repo fetches from
upstream.
However, this only happens
git-poll-intervalafter the mirroringhas started, and most of the time when the sync loop starts, the git
repo isn't ready. That means the first successful sync, for a
freshly-configured fluxd, is usually five minutes after starting.
To compensate, this commit makes the repo signal on the cell when it
moves to the ready state.