Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

helm-op: Add git hosts to known hosts in /etc/ssh/ssh_known_hosts #1188

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

stefanprodan
Copy link
Member

Port the know hosts changes from Flux to Flux Helm Operator ref #1154

@stefanprodan stefanprodan requested a review from squaremo July 2, 2018 14:17
@squaremo squaremo changed the title Add git hosts to known hosts in /etc/ssh/ssh_known_hosts helm-op: Add git hosts to known hosts in /etc/ssh/ssh_known_hosts Jul 2, 2018
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a faithful port of the changes, and seems like that's what is needed. Thanks Stefan ⭐

@stefanprodan stefanprodan merged commit 2356441 into master Jul 2, 2018
@stefanprodan stefanprodan deleted the fixhelm branch July 2, 2018 14:32
@stephenmoloney
Copy link
Contributor

This change will surely impact the helm chart which uses /root/.ssh/known_hosts as the dir ... I'll make a PR for that.

stephenmoloney added a commit to stephenmoloney/flux that referenced this pull request Jul 2, 2018
What does this PR do?

- Changes the mount path for known_hosts

Why is this PR needed?

- To bring the helm templates inline with the changes to the Dockerfile
in PR fluxcd#1188.
@squaremo
Copy link
Member

squaremo commented Jul 2, 2018

This change will surely impact the helm chart which uses /root/.ssh/known_hosts as the dir ... I'll make a PR for that.

The git code will look in both places; so it is intended that the image has the config and known_hosts in /etc/ssh/, and the chart mounts them into /root/.ssh/.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants