This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Check that chart exists when updating its deps #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to fail at updating chart dependencies when a chart doesn't have a requirements.yaml file (which is optional, for a chart). However, we _do_ want to fail if the chart doesn't exist in the filesystem at all.
hiddeco
approved these changes
Dec 17, 2018
|
Diligent! Thanks Hidde |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI failure that resulted from #1562 and #1561 interacting: the latter makes
updateDependenciessucceed trivially if therequirements.yamlfile is missing, but accidentally also succeeds if the entire chart is missing. The latter tests specifically thatupdateDependencieswill fail if the chart is missing.We don't want to fail at updating chart dependencies when a chart doesn't have a requirements.yaml file (which is optional, for a chart). However, we do want to fail if the chart doesn't exist in the filesystem at all.