This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Do not require 'values' object in HelmRelease CRD #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People sometimes just want to deploy a chart without setting any custom
values. Before this commit this required setting a `values: {}` in the
HelmRelease, which was quite inconvenient.
Change to the CRD only is sufficient as the code already takes, not
receiving values, into account.
squaremo
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1812
People sometimes just want to deploy a chart without setting any custom values. Before this commit this required setting a
values: {}in theHelmRelease, which was quite inconvenient.Change to the CRD only is sufficient as the code already takes, not receiving values, into account.