This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Initialize klog flags so it logs to stderr #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/init-klog-flags
branch
from
4b0f1ad to
f4e7dc0
Compare
2opremio
reviewed
Apr 16, 2019
This got not caught in CircleCI as it does not perform a rebase on-top of latest master before testing. We bumped client-go a while ago which included a switch to klog, the klog flags need to be intialized before they can be set, as we did not have this initialization in place, the operator was unable to start. As logging to stderr is now the default for klog; only initialize the flags so it is enabled.
hiddeco
force-pushed
the
helm/init-klog-flags
branch
from
f4e7dc0 to
780db3a
Compare
hiddeco
changed the title
|
Ah they fixed it in Kubernetes 1.14 |
stefanprodan
approved these changes
Apr 16, 2019
|
@2opremio I am going to merge this to get master going again, if you have any additional comments I will be happy to address them in another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got not caught in CircleCI as it does not perform a rebase
on-top of latest master before testing.
We bumped client-go a while ago (#1829) which included a switch to klog,
the klog flags need to be intialized before they can be set, as we did
not have this initialization in place, the operator was unable to
start. Simply initialize the flags and we are good to go.
I am tempted to add the following to the CircleCI config in a separate PR to prevent this in the future:
if [[ "$CIRCLE_BRANCH" != "master" && "$CIRCLE_BRANCH" != release* ]]; then git fetch origin master && git rebase origin/master; fi