This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Log and return early if release is not upgradable #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/do-not-attempt-install-on-release-failure
branch
from
b83925a to
82a9ffe
Compare
stefanprodan
approved these changes
May 2, 2019
Before this change the operator would follow the installation path if a Helm release was not in a 'DEPLOYED' state, which would fail later on as a release with the name already existed. We now detect what the state of the release is and return (and log) a descriptive error message in case we can not upgrade the release.
hiddeco
force-pushed
the
helm/do-not-attempt-install-on-release-failure
branch
from
82a9ffe to
886048d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the operator would follow the installation path if
a Helm release was not in a 'DEPLOYED' state, which would fail later on
as a release with the name already existed.
We now detect what the state of the release is and return (and log)
a descriptive error message in case we can not upgrade the release.