New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metric 'log_messages_total' to match Prometheus conventions #11

Closed

bboreham opened this issue Jul 28, 2018 · 0 comments

Contributor

bboreham commented Jul 28, 2018

log_messages should really be log_messages_total

https://prometheus.io/docs/practices/naming/

Note that an accumulating count has total as a suffix, in addition to the unit if applicable.

The text was updated successfully, but these errors were encountered:

bboreham mentioned this issue

Unify the server logs and the gokit logging. cortexproject/cortex#870

Merged

marccarre mentioned this issue

Promrus' counters now follow Prometheus' naming conventions #12

Merged

marccarre closed this as completed in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment